From: Ingo Molnar <mingo@elte.hu>
To: Arnaldo Carvalho de Melo <acme@infradead.org>
Cc: linux-kernel@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
Paul Mackerras <paulus@samba.org>, Mike Galbraith <efault@gmx.de>
Subject: Re: [PATCH] perf tools: Delay loading symtabs till we hit a map with it
Date: Thu, 29 Oct 2009 08:24:33 +0100 [thread overview]
Message-ID: <20091029072433.GF12874@elte.hu> (raw)
In-Reply-To: <1256773881-4191-1-git-send-email-acme@infradead.org>
* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> From: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> So that we can have a quicker start on perf top and even speedups in the
> other tools, as we can have maps with no hits, so no need to load its
> symtabs.
>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Mike Galbraith <efault@gmx.de>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> ---
> tools/perf/builtin-annotate.c | 4 ++--
> tools/perf/builtin-report.c | 4 ++--
> tools/perf/builtin-top.c | 5 ++---
> tools/perf/util/event.h | 4 +++-
> tools/perf/util/map.c | 40 ++++++++++++++++++++++++----------------
> tools/perf/util/symbol.c | 16 +++++++++-------
> tools/perf/util/symbol.h | 4 ++--
> 7 files changed, 44 insertions(+), 33 deletions(-)
ok, that's a really nice feature - i noticed the occasional symtab
loading overhead in tools.
Ingo
next prev parent reply other threads:[~2009-10-29 7:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-28 23:51 Arnaldo Carvalho de Melo
2009-10-29 7:24 ` Ingo Molnar [this message]
2009-10-29 8:06 ` [tip:perf/core] " tip-bot for Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091029072433.GF12874@elte.hu \
--to=mingo@elte.hu \
--cc=acme@infradead.org \
--cc=acme@redhat.com \
--cc=efault@gmx.de \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome