From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: "Joseph S. Myers" <joseph@codesourcery.com>,
linux-api@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>,
Oleg Nesterov <onestero@redhat.com>,
Stephane Eranian <eranian@googlemail.com>,
Michael Kerrisk <mtk.manpages@googlemail.com>,
Roland McGrath <roland@redhat.com>,
Al Viro <viro@ZenIV.linux.org.uk>,
Christoph Hellwig <hch@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: F_SETOWN_EX and F_GETLK64 conflict
Date: Fri, 30 Oct 2009 16:13:20 +1100 [thread overview]
Message-ID: <20091030161320.17d07dc9.sfr@canb.auug.org.au> (raw)
In-Reply-To: <1254691822.21044.9.camel@laptop>
[-- Attachment #1: Type: text/plain, Size: 768 bytes --]
Hi Peter,
On Sun, 04 Oct 2009 23:30:22 +0200 Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
>
> On Sun, 2009-10-04 at 12:35 +0000, Joseph S. Myers wrote:
> > In asm-generic/fcntl.h, F_SETOWN_EX and F_GETLK64 both have value 12, and
> > F_GETOWN_EX and F_SETLK64 both have value 13. I don't see how this is
> > going to work correctly. See
> > <http://sourceware.org/ml/libc-ports/2009-10/msg00013.html>.
>
>
> Ugh,.. yeah, non obvious collision that.
This is why we have F_LINUX_SPECIFIC_BASE and use it in
include/linux/fcntl.h ... it should be used as a base for any new fcntl
types since they don't require backward compatibility.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2009-10-30 5:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.64.0910041229300.20203@digraph.polyomino.org.uk>
2009-10-04 21:30 ` Peter Zijlstra
2009-10-29 17:03 ` Andreas Schwab
2009-10-30 3:21 ` Ulrich Drepper
2009-10-30 5:13 ` Stephen Rothwell [this message]
2009-10-30 5:29 ` Stephen Rothwell
2009-11-12 23:32 ` Stephen Rothwell
2009-11-14 7:01 ` [PATCH] fcntl: use architecture independent values for new fcntl operations Stephen Rothwell
2009-11-14 9:45 ` [PATCH v2] fcntl: Use consistent values for F_[GS]ETOWN_EX Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091030161320.17d07dc9.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=eranian@googlemail.com \
--cc=hch@infradead.org \
--cc=joseph@codesourcery.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mtk.manpages@googlemail.com \
--cc=onestero@redhat.com \
--cc=roland@redhat.com \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®