mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Huang Ying <ying.huang@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
	Daniel Walker <dwalker@fifo99.com>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH -v4] crypto: Add PCLMULQDQ accelerated GHASH implementation
Date: Mon, 2 Nov 2009 08:50:39 +0100	[thread overview]
Message-ID: <20091102075039.GA15942@elte.hu> (raw)
In-Reply-To: <20091101175043.GA25257@gondor.apana.org.au>


* Herbert Xu <herbert@gondor.apana.org.au> wrote:

> -	pshufb BSWAP, DATA
> +	# pshufb BSWAP, DATA
> +	.byte 0x66, 0x0f, 0x38, 0x00, 0xc5

A cleanup request: mind creating two macros for this PSHUFB MMX/SSE 
instruction in arch/x86/include/asm/i387.h, instead of open-coding the 
.byte sequences in ~6 places?

( After the .33 merge window we'll collect such instruction format 
  knowledge in arch/x86/include/asm/inst.h. That file is not upstream 
  yet so i387.h will do for now for FPU/SSE instructions. )

Thanks,

	Ingo

  reply	other threads:[~2009-11-02  7:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-16  1:35 Huang Ying
2009-10-19  2:53 ` Herbert Xu
2009-11-01  0:30   ` Andrew Morton
2009-11-01 17:50     ` Herbert Xu
2009-11-02  7:50       ` Ingo Molnar [this message]
2009-11-02 14:28         ` Herbert Xu
2009-11-02 14:32           ` Ingo Molnar
2009-11-02 14:46             ` Herbert Xu
2009-11-02 15:46               ` Ingo Molnar
2009-11-03 14:12                 ` Herbert Xu
2009-11-03  5:47             ` Huang Ying
2009-11-03  9:03               ` Ingo Molnar
2009-11-04  0:59                 ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091102075039.GA15942@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=dwalker@fifo99.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=hpa@zytor.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®