Re: [RFC][PATCH 2/7] Adding general performance benchmarking subsystem to perf.

[Ingo Molnar <mingo@elte.hu>]

* Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp> wrote:

> 
> Adding general performance benchmarking subsystem to perf.
> This patch add new file: bench-suite.h
> 
> bench-suite.h contains prototypes of benchmark suite functions.
> 
> Signed-off-by: Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>
> Cc: Rusty Russell <rusty@rustcorp.com.au>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Cc: Mike Galbraith <efault@gmx.de>
> ---
>  tools/perf/bench-suite.h |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
>  create mode 100644 tools/perf/bench-suite.h
> 
> diff --git a/tools/perf/bench-suite.h b/tools/perf/bench-suite.h
> new file mode 100644
> index 0000000..65f6f55
> --- /dev/null
> +++ b/tools/perf/bench-suite.h
> @@ -0,0 +1,7 @@
> +#ifndef BENCH_SUITE_H
> +#define BENCH_SUITE_H
> +
> +extern int bench_sched_messaging(int argc, const char **argv, const char *prefix);
> +extern int bench_sched_pipe(int argc, const char **argv, const char *prefix);
> +
> +#endif

Please put new headers into tools/*.h.

Also, could we name it bench.h? It's a bit shorter :)

	Ingo