From: Sam Ravnborg <sam@ravnborg.org>
To: Huang Ying <ying.huang@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Joe Perches <joe@perches.com>,
Steven Whitehouse <swhiteho@redhat.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC 2/2] Use unified UUID/GUID definition in gfs2
Date: Tue, 3 Nov 2009 11:02:32 +0100 [thread overview]
Message-ID: <20091103100232.GA489@merkur.ravnborg.org> (raw)
In-Reply-To: <1257232919.22519.40.camel@yhuang-dev.sh.intel.com>
On Tue, Nov 03, 2009 at 03:21:59PM +0800, Huang Ying wrote:
> On Tue, 2009-11-03 at 09:02 +0800, Andrew Morton wrote:
> > On Tue, 03 Nov 2009 08:44:48 +0800
> > Huang Ying <ying.huang@intel.com> wrote:
> >
> > > For stuff of no use to user space, I think it can be enclosed into
> > >
> > > #ifdef __KERNEL__
> > > #endif
> >
> > It can, but that's ugly. Clearly separating the inclusions into uuid-kernel.h
> > and uuid-user-h is nicer, no?
>
> But it seems that __KERNEL__ is common used method now. There are about
> 370 out of 3085 files under linux/include use __KERNEL__.
Just because we were sloopy in the past is no excuse for repeating this.
Sam
prev parent reply other threads:[~2009-11-03 10:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-14 6:30 Huang Ying
2009-11-01 17:35 ` Andrew Morton
2009-11-02 0:59 ` Huang Ying
2009-11-02 23:02 ` Andrew Morton
2009-11-03 0:44 ` Huang Ying
2009-11-03 1:02 ` Andrew Morton
2009-11-03 7:21 ` Huang Ying
2009-11-03 10:02 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091103100232.GA489@merkur.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@linux-foundation.org \
--cc=joe@perches.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=swhiteho@redhat.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®