From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Andrew Morton <akpm@linux-foundation.org>,
James Bottomley <James.Bottomley@suse.de>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
linux-scsi@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] strstrip incorrectly marked __must_check
Date: Tue, 3 Nov 2009 19:10:06 +0000 [thread overview]
Message-ID: <20091103191006.30e8be36@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20091103190420.GY10555@parisc-linux.org>
On Tue, 3 Nov 2009 12:04:20 -0700
Matthew Wilcox <matthew@wil.cx> wrote:
>
> static inline void strsrip_tail(char *str)
> {
> - char *x __used;
> - x = strstrip(str);
> + char *x = strstrip(str);
> + BUG_ON(x != str);
That breaks it. It was fine before you did that but now it blows up if
there are leading spaces.
next prev parent reply other threads:[~2009-11-03 19:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-03 18:38 James Bottomley
2009-11-03 18:59 ` Andrew Morton
2009-11-03 19:04 ` Matthew Wilcox
2009-11-03 19:06 ` KOSAKI Motohiro
2009-11-03 19:10 ` Alan Cox [this message]
2009-11-03 19:11 ` James Bottomley
2009-11-03 19:10 ` James Bottomley
2009-11-03 19:12 ` Alan Cox
2009-11-03 19:58 ` KOSAKI Motohiro
2009-11-23 13:04 ` Michael Holzheu
2009-11-24 8:55 ` KOSAKI Motohiro
2009-11-24 9:09 ` Michael Holzheu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091103191006.30e8be36@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=James.Bottomley@suse.de \
--cc=akpm@linux-foundation.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®