From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>,
linux-kernel@vger.kernel.org, david-b@pacbell.net,
Greg KH <greg@kroah.com>, Kay Sievers <kay.sievers@vrfy.org>,
Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH] gpiolib: fix device_create() result check
Date: Tue, 3 Nov 2009 23:47:47 +0000 [thread overview]
Message-ID: <20091103234747.59c0e2ca@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20091103144401.6fa4e130.akpm@linux-foundation.org>
On Tue, 3 Nov 2009 14:44:01 -0800
Andrew Morton <akpm@linux-foundation.org> wrote:
> On Tue, 20 Oct 2009 20:35:23 +0400
> Sergei Shtylyov <sshtylyov@ru.mvista.com> wrote:
>
> > In case of failure, device_create() returns not NULL but the error code.
> > The current code checks for non-NULL though which causes kernel oops in
> > sysfs_create_group() when device_create() fails. Check for error using
> > IS_ERR() and propagate the error value using PTR_ERR() instead of fixed
> > -ENODEV code returned now...
>
> Does anyone notice any missing information here?
its what you get for cheap hacks instead of having a ptr_err_t which is a
union so you have to get it right ;)
Alan
next prev parent reply other threads:[~2009-11-03 23:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-20 16:35 Sergei Shtylyov
2009-11-03 22:44 ` Andrew Morton
2009-11-03 23:47 ` Alan Cox [this message]
2009-11-04 0:02 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091103234747.59c0e2ca@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=david-b@pacbell.net \
--cc=greg@kroah.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®