From: Pavel Machek <pavel@ucw.cz>
To: Paul Fertser <fercerpav@gmail.com>
Cc: Anton Vorontsov <cbou@mail.ru>,
David Woodhouse <dwmw2@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/6] power: pcf50633: properly reenable charging when the supply conditions change
Date: Wed, 4 Nov 2009 22:46:22 +0100 [thread overview]
Message-ID: <20091104214622.GA27325@elf.ucw.cz> (raw)
In-Reply-To: <1257369899-325-5-git-send-email-fercerpav@gmail.com>
On Thu 2009-11-05 00:24:58, Paul Fertser wrote:
> If chgmod == BATFULL, setting chgena has no effect. Datasheet says we
> need to set resume instead but when autoresume is used resume doesn't
> work. Clear and set chgena instead.
>
> This enables a user to force charging by re-plugging USB even when the
> charger entered Battery Full mode, might be handy before a long
> trip.
And is against manufacturer recommendation and will unneccessary
shorted life of battery with frequent plugs/unplugs. Is it good idea?
If you want to "top-up" the battery, perhaps that should be on
explicit request, like something in /sys?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2009-11-04 21:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-04 21:24 [PATCH 1/6] power: pcf50633: add ac power supply class to the charger Paul Fertser
2009-11-04 21:24 ` [PATCH 2/6] power: pcf50633: introduces battery charging current control Paul Fertser
2009-11-04 21:24 ` [PATCH 3/6] gta02: set pcf50633 charger_reference_current_ma Paul Fertser
2009-11-04 21:24 ` [PATCH 4/6] power: pcf50633: get rid of charging restart software auto-triggering Paul Fertser
2009-11-04 21:24 ` [PATCH 5/6] power: pcf50633: properly reenable charging when the supply conditions change Paul Fertser
2009-11-04 21:24 ` [PATCH 6/6] power: pcf50633: query charger status directly Paul Fertser
2009-11-04 21:46 ` Pavel Machek [this message]
2009-11-04 22:24 ` [PATCH 5/6] power: pcf50633: properly reenable charging when the supply conditions change Paul Fertser
2009-11-04 23:16 ` Pavel Machek
2009-11-04 23:45 ` Anton Vorontsov
2009-11-04 23:56 ` Pavel Machek
2009-11-11 13:48 ` [PATCH 3/6] gta02: set pcf50633 charger_reference_current_ma Paul Fertser
2009-11-11 15:31 ` Anton Vorontsov
2009-11-12 7:40 ` Pavel Machek
2009-11-12 21:59 ` Russell King - ARM Linux
2009-11-13 18:26 ` Pavel Machek
2009-11-16 1:00 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091104214622.GA27325@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=cbou@mail.ru \
--cc=dwmw2@infradead.org \
--cc=fercerpav@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®