From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Amit Shah <amit.shah@redhat.com>
Cc: linux-kernel@vger.kernel.org, rusty@rustcorp.com.au,
virtualization@linux-foundation.org
Subject: Re: [PATCH v10 1/1] virtio_console: Add support for multiple ports for generic guest and host communication
Date: Fri, 6 Nov 2009 08:43:05 +0100 [thread overview]
Message-ID: <200911060843.05934.borntraeger@de.ibm.com> (raw)
In-Reply-To: <1257266319-24300-2-git-send-email-amit.shah@redhat.com>
Am Dienstag 03 November 2009 17:38:39 schrieb Amit Shah:
> drivers/char/Kconfig | 6 +
> drivers/char/virtio_console.c | 1412 ++++++++++++++++++++++++++++++++++++----
> include/linux/virtio_console.h | 50 ++-
> 3 files changed, 1332 insertions(+), 136 deletions(-)
I have not looked at your last two versions of the patch since you did not add
a changelog to your patch description. I thought you only did minor changes.
Turned out you added/changed several places. (e.g. VIRTIO_CONSOLE_CACHE_BUFFERS,
VIRTIO_CONSOLE_THROTTLE_PORT and VIRTIO_CONSOLE_BUFFER_LIMIT are all new)
When you do bigger changes can you add a changelog in your patch description in
the future?
next prev parent reply other threads:[~2009-11-06 7:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-03 16:38 [PATCH v10 0/1] virtio-console: Support for generic ports and multiple consoles Amit Shah
2009-11-03 16:38 ` [PATCH v10 1/1] virtio_console: Add support for multiple ports for generic guest and host communication Amit Shah
2009-11-06 7:10 ` Rusty Russell
2009-11-06 8:00 ` Christian Borntraeger
2009-11-06 13:00 ` Anthony Liguori
2009-11-06 14:12 ` Christian Borntraeger
2009-11-06 14:32 ` Anthony Liguori
2009-11-09 12:08 ` Amit Shah
2009-11-10 2:19 ` Rusty Russell
2009-11-06 7:43 ` Christian Borntraeger [this message]
2009-11-09 12:09 ` Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200911060843.05934.borntraeger@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=amit.shah@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®