mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Andr? Goddard Rosa <andre.goddard@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
	laijs@cn.fujitsu.com, davem@davemloft.net,
	akpm@linux-foundation.org, harvey.harrison@gmail.com,
	linux list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/7] vsprintf: factorize "(null)" string
Date: Sun, 8 Nov 2009 12:02:37 +0100	[thread overview]
Message-ID: <20091108110237.GG11372@elte.hu> (raw)
In-Reply-To: <b8bf37780911040648h7e4bae3dg21ce15c6b0e680d3@mail.gmail.com>


* Andr? Goddard Rosa <andre.goddard@gmail.com> wrote:

> @@ -546,12 +548,12 @@ static char *number(char *buf, char *end,
> unsigned long long num,
>  	return buf;
>  }
> 
> -static char *string(char *buf, char *end, char *s, struct printf_spec spec)
> +static char *string(char *buf, char *end, const char *s, struct
> printf_spec spec)

FYI, your patches have such linewraps, so the patches wont apply:

 patch: **** malformed patch at line 47: unsigned long long num,

See Documentation/email-clients.txt about how to send patches without 
such problems.

Mind resending with this fixed?

Also, this RFC patch of yours:

  vsprintf: reuse almost identical simple_strtoulX() functions

looks nice too IMO - mind including it in your series?

Thanks,

	Ingo


  reply	other threads:[~2009-11-08 11:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-04 14:48 André Goddard Rosa
2009-11-08 11:02 ` Ingo Molnar [this message]
2009-11-08 15:36   ` André Goddard Rosa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091108110237.GG11372@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=andre.goddard@gmail.com \
    --cc=davem@davemloft.net \
    --cc=fweisbec@gmail.com \
    --cc=harvey.harrison@gmail.com \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®