mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org,
	hare@suse.de, akpm@linux-foundation.org, tglx@linutronix.de,
	linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/urgent] x86: Add back _end symbol that is missing from Symbol.map
Date: Sun, 8 Nov 2009 13:38:25 +0100	[thread overview]
Message-ID: <20091108123825.GA11904@merkur.ravnborg.org> (raw)
In-Reply-To: <20091108114829.GQ11372@elte.hu>

On Sun, Nov 08, 2009 at 12:48:29PM +0100, Ingo Molnar wrote:
> 
> * Sam Ravnborg <sam@ravnborg.org> wrote:
> 
> > On Sun, Nov 08, 2009 at 11:07:12AM +0000, tip-bot for Hannes Reinecke wrote:
> > > Commit-ID:  d1e4d37b79e944f6351ae38eb1ca7c9f7b506e76
> > > Gitweb:     http://git.kernel.org/tip/d1e4d37b79e944f6351ae38eb1ca7c9f7b506e76
> > > Author:     Hannes Reinecke <hare@suse.de>
> > > AuthorDate: Wed, 4 Nov 2009 07:19:32 -0800
> > > Committer:  Ingo Molnar <mingo@elte.hu>
> > > CommitDate: Sun, 8 Nov 2009 12:05:03 +0100
> > > 
> > > x86: Add back _end symbol that is missing from Symbol.map
> > > 
> > > With 2.6.31 'crash' on x86_64 falls flat on its face as the
> > > '_end' symbol is missing from the System.map file.
> > > 
> > > The culprit is commit 091e52c3551d3031343df24b573b770b4c6c72b6,
> > > which moved the '_end' symbol into it's own section.  Apparently
> > > this causes kallsyms to not reference it properly.
> > > 
> > > So do not include _end in it's own section.
> > > 
> > > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> > > Cc: Sam Ravnborg <sam@ravnborg.org>
> > > Cc: <stable@kernel.org> # .31.x
> > > LKML-Reference: <200911041519.nA4FJWEW030164@imap1.linux-foundation.org>
> > > Signed-off-by: Ingo Molnar <mingo@elte.hu>
> > 
> > I'm afraid this will break a RELOCTABLE i386 kernel.
> > 
> > We fixed this up some time ago where we had to
> > move the symbol definition inside a section
> > to prevent the symbol being absolute.
> 
> ah, indeed. So ... the question is then, why did _end disappear from 
> System.map?
I think ld discards zero size sections. No need to keep them around
if they are empty.

Following patch should fix it up in a better way.
I reused most of Hannes changelog.

	Sam

[PATCH] x86: Add back _end symbol that is missing from Symbol.map

With 2.6.31 'crash' on x86_64 falls flat on its face as the
'_end' symbol is missing from the System.map file.

The culprit is commit 091e52c3551d3031343df24b573b770b4c6c72b6,
which moved the '_end' symbol into it's own section.

The problem is likely that ld discards empty sections.
So move the definition of _end into the last section defined.

Cc: Hannes Reinecke <hare@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: <stable@kernel.org> # .31.x
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>


diff --git a/arch/x86/kernel/vmlinux.lds.S b/arch/x86/kernel/vmlinux.lds.S
index 92929fb..c58a6e3 100644
--- a/arch/x86/kernel/vmlinux.lds.S
+++ b/arch/x86/kernel/vmlinux.lds.S
@@ -289,9 +289,12 @@ SECTIONS
 		. += 64 * 1024;		/* 64k alignment slop space */
 		*(.brk_reservation)	/* areas brk users have reserved */
 		__brk_limit = .;
-	}
 
-	.end : AT(ADDR(.end) - LOAD_OFFSET) {
+		/*
+		 * To support RELOCTABLE kernel _end must be inside a section.
+		 * And ld is know to discard empty section so we locate _end in
+		 * last section we define.
+		 */
 		_end = .;
 	}
 

  reply	other threads:[~2009-11-08 12:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200911041519.nA4FJWEW030164@imap1.linux-foundation.org>
2009-11-08 11:07 ` tip-bot for Hannes Reinecke
2009-11-08 11:38   ` Sam Ravnborg
2009-11-08 11:48     ` Ingo Molnar
2009-11-08 12:38       ` Sam Ravnborg [this message]
2009-11-08 12:42         ` Ingo Molnar
2009-11-09 18:40         ` H. Peter Anvin
2009-12-14 22:27           ` [tip:x86/urgent] x86: Regex support and known-movable symbols for relocs, fix _end tip-bot for H. Peter Anvin
2009-11-08 16:36     ` [tip:x86/urgent] x86: Add back _end symbol that is missing from Symbol.map H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091108123825.GA11904@merkur.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=akpm@linux-foundation.org \
    --cc=hare@suse.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®