From: Ali Gholami Rudi <ali@rudi.ir>
To: Patrick Ohly <patrick.ohly@intel.com>
Cc: "trivial@kernel.org" <trivial@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] trivial: fix checking socket() in net tstamp example
Date: Sun, 8 Nov 2009 21:27:04 +0330 [thread overview]
Message-ID: <20091108175704.GB820@lilem.mirepesht> (raw)
In-Reply-To: <1257701045.29123.288.camel@pohly-mobl1.ikn.intel.com>
Hi Patrick,
Patrick Ohly <patrick.ohly@intel.com> wrote:
> > --- a/Documentation/networking/timestamping/timestamping.c
> > +++ b/Documentation/networking/timestamping/timestamping.c
> > @@ -370,7 +370,7 @@ int main(int argc, char **argv)
> > }
> >
> > sock = socket(PF_INET, SOCK_DGRAM, IPPROTO_UDP);
> > - if (socket < 0)
> > + if (sock < 0)
>
> Argh, of course you are right. FWIW, acknowledged.
By the way, I tried igb hardware timestamp but HWTSTAMP_FILTER_ALL works
almost like HWTSTAMP_FILTER_PTP_*. Isn't it supposed to timestamp all
of the incoming packets? Maybe there is something wrong with my test
setup?
Thanks,
Ali
next prev parent reply other threads:[~2009-11-08 17:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-08 15:59 Ali Gholami Rudi
2009-11-08 17:24 ` Patrick Ohly
2009-11-08 17:57 ` Ali Gholami Rudi [this message]
2009-11-08 20:19 ` What's the state of the TX timestamping? Emilio G. Cota
2009-12-18 14:23 ` [PATCH] trivial: fix checking socket() in net tstamp example Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091108175704.GB820@lilem.mirepesht \
--to=ali@rudi.ir \
--cc=davem@davemloft.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrick.ohly@intel.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®