From: Roland McGrath <roland@redhat.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: [PATCH] ptrace: copy_process() should disable stepping
Date: Sun, 8 Nov 2009 20:15:46 -0800 (PST) [thread overview]
Message-ID: <20091109041546.925461E@magilla.sf.frob.com> (raw)
In-Reply-To: Oleg Nesterov's message of Saturday, 7 November 2009 22:55:47 +0100 <20091107215547.GA25335@redhat.com>
That is inappropriate use of arch details in generic code. It might
happen to be harmless fritter in practice on the arch's we have but it
is certainly not the correct way to go about things. You should just
call user_disable_single_step() unconditionally. Even on an arch with
no such machinery at all that should be defined safely as a no-op (see
linux/ptrace.h). If there is some reason not to do that, please
explain it.
Thanks,
Roland
next prev parent reply other threads:[~2009-11-09 4:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-06 21:16 [PATCH] ptrace: copy_thread() should clear TIF_SINGLESTEP and X86_EFLAGS_TF Oleg Nesterov
2009-11-06 21:25 ` Roland McGrath
2009-11-06 21:50 ` Oleg Nesterov
2009-11-06 22:10 ` Roland McGrath
2009-11-07 21:55 ` [PATCH] ptrace: copy_process() should disable stepping Oleg Nesterov
2009-11-09 4:15 ` Roland McGrath [this message]
2009-11-09 16:24 ` Oleg Nesterov
2009-11-09 23:53 ` [PATCH v2] " Oleg Nesterov
2009-11-10 20:39 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091109041546.925461E@magilla.sf.frob.com \
--to=roland@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®