From: Andi Kleen <andi@firstfloor.org>
To: Andre Przywara <andre.przywara@amd.com>
Cc: Andi Kleen <andi@firstfloor.org>,
Linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: x86/NUMA: Reason for ignoring too small NUMA nodes?
Date: Mon, 9 Nov 2009 13:38:24 +0100 [thread overview]
Message-ID: <20091109123824.GE26740@basil.fritz.box> (raw)
In-Reply-To: <4AF80AA3.9020400@amd.com>
On Mon, Nov 09, 2009 at 01:27:15PM +0100, Andre Przywara wrote:
> while experimenting with a system with a memory-less NUMA node I stumbled
> upon code in the Linux kernel which ignores nodes containing less than a
> certain amount of RAM, obviously to fix systems with a buggy BIOS.
> Can you elaborate on this? What kind of incorrect entry have you seen?
> To correctly map the memory less node I did a patch to accept at least
> nodes with exactly zero bytes of memory (read: no SRAT memory entry), was
> this special condition also present in the buggy machines?
It was a misparsed numa node, not zero. I don't remember if
the bug was in Linux or in the BIOS. This was a sanity check
to catch all such cases. I haven't seen misparsed nodes for quite some
time, so in theory it could be removed I guess.
Zero size node were back then not supported in the VM. I still think
the concept doesn't make too much sense: a memory range without
memory (and it bitrots all the time even today, see recent patches)
-Andi
prev parent reply other threads:[~2009-11-09 12:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-09 12:27 Andre Przywara
2009-11-09 12:38 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091109123824.GE26740@basil.fritz.box \
--to=andi@firstfloor.org \
--cc=andre.przywara@amd.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®