From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755255AbZKIRJI (ORCPT ); Mon, 9 Nov 2009 12:09:08 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754835AbZKIRJG (ORCPT ); Mon, 9 Nov 2009 12:09:06 -0500 Received: from relay1.sgi.com ([192.48.179.29]:37895 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755056AbZKIRJD (ORCPT ); Mon, 9 Nov 2009 12:09:03 -0500 From: Robin Holt Message-Id: <20091109170907.436556000@alcatraz.americas.sgi.com> User-Agent: quilt/0.47-1 Date: Mon, 09 Nov 2009 11:09:00 -0600 To: Ingo Molnar Cc: Robin Holt , Jack Steiner , linux-kernel Subject: [patch 6/6] X86: UV - xpc_make_first_contact hang due to not accepting ACTIVE state. References: <20091109170854.161447000@alcatraz.americas.sgi.com> Content-Disposition: inline; filename=xpc_first_contact_when_active Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Many times while the initial connection is being made, the contacted partition will send back both the ACTIVATING and the ACTIVE remote_act_state changes in very close succescion. The 1/4 second delay in the make first contact loop is large enough to nearly always miss the ACTIVATING state change. Since either state indicates the remote partition has acknowledged our state change, accept either. To: Ingo Molnar Signed-off-by: Robin Holt Cc: Jack Steiner Cc: lkml --- drivers/misc/sgi-xp/xpc_uv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Index: linux-x86/drivers/misc/sgi-xp/xpc_uv.c =================================================================== --- linux-x86.orig/drivers/misc/sgi-xp/xpc_uv.c 2009-11-09 09:13:14.000000000 -0600 +++ linux-x86/drivers/misc/sgi-xp/xpc_uv.c 2009-11-09 09:13:14.000000000 -0600 @@ -1022,7 +1022,8 @@ xpc_make_first_contact_uv(struct xpc_par xpc_send_activate_IRQ_part_uv(part, &msg, sizeof(msg), XPC_ACTIVATE_MQ_MSG_SYNC_ACT_STATE_UV); - while (part->sn.uv.remote_act_state != XPC_P_AS_ACTIVATING) { + while (!((part->sn.uv.remote_act_state == XPC_P_AS_ACTIVATING) || + (part->sn.uv.remote_act_state == XPC_P_AS_ACTIVE))) { dev_dbg(xpc_part, "waiting to make first contact with " "partition %d\n", XPC_PARTID(part));