From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Joe Perches <joe@perches.com>
Cc: Alan Cox <alan@linux.intel.com>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] parport_pc.c: Use correct length in strncmp
Date: Tue, 10 Nov 2009 10:25:18 +0000 [thread overview]
Message-ID: <20091110102518.7c3fc47c@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <1257825083.12852.83.camel@Joe-Laptop.home>
On Mon, 09 Nov 2009 19:51:23 -0800
Joe Perches <joe@perches.com> wrote:
> Signed-off-by: Joe Perches <joe@perches.com>
>
> diff --git a/drivers/parport/parport_pc.c b/drivers/parport/parport_pc.c
> index 2597145..ad113b0 100644
> --- a/drivers/parport/parport_pc.c
> +++ b/drivers/parport/parport_pc.c
> @@ -3403,7 +3403,7 @@ static int __init parport_parse_param(const char *s, int *val,
> *val = automatic;
> else if (!strncmp(s, "none", 4))
> *val = none;
> - else if (nofifo && !strncmp(s, "nofifo", 4))
> + else if (nofifo && !strncmp(s, "nofifo", 6))
> *val = nofifo;
I just hope nobody is booting with =nofif due to a typo ;)
Acked-by: Alan Cox <alan@linux.intel.com>
prev parent reply other threads:[~2009-11-10 10:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-10 3:51 Joe Perches
2009-11-10 10:25 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091110102518.7c3fc47c@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=alan@linux.intel.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®