From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758452AbZKJV7S (ORCPT ); Tue, 10 Nov 2009 16:59:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752044AbZKJV7S (ORCPT ); Tue, 10 Nov 2009 16:59:18 -0500 Received: from mx3.mail.elte.hu ([157.181.1.138]:57866 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751238AbZKJV7R (ORCPT ); Tue, 10 Nov 2009 16:59:17 -0500 Date: Tue, 10 Nov 2009 22:57:59 +0100 From: Ingo Molnar To: Yinghai Lu Cc: David Rientjes , Mike Travis , Thomas Gleixner , Andrew Morton , Jack Steiner , "H. Peter Anvin" , x86@kernel.org, Mel Gorman , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, Andi Kleen Subject: Re: [patch v2] x86: reduce srat verbosity in the kernel log Message-ID: <20091110215759.GG23196@elte.hu> References: <4AE75162.7080903@sgi.com> <20091028033219.GE7744@basil.fritz.box> <20091028041159.GI7744@basil.fritz.box> <20091110213312.GE23196@elte.hu> <4AF9DE50.50807@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4AF9DE50.50807@kernel.org> User-Agent: Mutt/1.5.20 (2009-08-17) X-ELTE-SpamScore: 0.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=0.0 required=5.9 tests=none autolearn=no SpamAssassin version=3.2.5 _SUMMARY_ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Yinghai Lu wrote: > Ingo Molnar wrote: > > * David Rientjes wrote: > > > >> On Tue, 27 Oct 2009, David Rientjes wrote: > >> > >>> x86: reduce srat verbosity in the kernel log > >>> > >>> It's possible to reduce the number of SRAT messages emitted to the kernel > >>> log by printing each valid pxm once and then creating bitmaps to represent > >>> the apic ids that map to the same node. > >>> > >>> This reduces lines such as > >>> > >>> SRAT: PXM 0 -> APIC 0 -> Node 0 > >>> SRAT: PXM 0 -> APIC 1 -> Node 0 > >>> SRAT: PXM 1 -> APIC 2 -> Node 1 > >>> SRAT: PXM 1 -> APIC 3 -> Node 1 > >>> > >>> to > >>> > >>> SRAT: PXM 0 -> APIC {0-1} -> Node 0 > >>> SRAT: PXM 1 -> APIC {2-3} -> Node 1 > >>> > >>> The buffer used to store the apic id list is 128 characters in length. > >>> If that is too small to represent all the apic id ranges that are bound > >>> to a single pxm, a trailing "..." is added. APICID_LIST_LEN should be > >>> manually increased for such configurations. > >>> > >>> Acked-by: Mike Travis > >>> Signed-off-by: David Rientjes > >> Ingo, have you had a chance to look at merging this yet? > > > > I'm waiting for Mike to test them (and other patches) and send a new > > series out with bits to pick up. > > > > But i really dont like such type of buffering - in the past they tended > > to be problematic. Why print this info at all in the default bootup? > > It's not needed on a correctly functioning system. > > > > For failure analysis make it opt-in available via a boot parameter (if > > it's needed for bootup analysis) - but otherwise just dont print it. > > > make them to depend on apic=debug or apic=verbose? Yeah - i'd definitely suggest to not splinter the boot flag space too much - users wont know what to enable in case of trouble. But that is a detail (and it can be improved later on as well). Ingo