mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Yinghai Lu <yhlu.kernel@gmail.com>,
	Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
	Ingo Molnar <mingo@elte.hu>, Matthew Wilcox <matthew@wil.cx>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: pci_find_parent_resource patch
Date: Wed, 11 Nov 2009 08:21:59 +0000	[thread overview]
Message-ID: <20091111082159.2a5b915b@jbarnes-x200> (raw)
In-Reply-To: <alpine.LFD.2.01.0911100745580.31845@localhost.localdomain>

On Tue, 10 Nov 2009 07:57:47 -0800 (PST)
Linus Torvalds <torvalds@linux-foundation.org> wrote:
> 	/* We can't insert a non-prefetch resource inside a
> prefetchable parent .. */ if (r->flags & IORESOURCE_PREFETCH)
> 		continue;
> 	/* .. but we can put a prefetchable resource inside a
> non-prefetchable one */ if (!best)
> 		best = r;
> 
>    instead. With the comments, it's now six lines instead of two, but
> it's conceptually simpler, and I _could_ have written it as two lines:
> 
> 	if ((res->flags & IORESOURCE_PREFETCH) && !best)
> 		best = r;	/* Approximating prefetchable by
> non-prefetchable */
> 
>    but I thought that was too damn subtle.
> 
> Feel free to use this long explanation as a commit message if you
> want,

Ok, I applied it to my linux-next tree.

Thanks,
Jesse

  reply	other threads:[~2009-11-11  8:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-09 20:04 Yinghai Lu
2009-11-10  8:23 ` Jesse Barnes
2009-11-10 10:05   ` Yinghai Lu
2009-11-10 15:57     ` Linus Torvalds
2009-11-11  8:21       ` Jesse Barnes [this message]
2009-11-25  0:22 Yinghai Lu
2009-12-04 23:59 ` Jesse Barnes
2009-12-05  0:24   ` Linus Torvalds
2009-12-05  0:30     ` Jesse Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091111082159.2a5b915b@jbarnes-x200 \
    --to=jbarnes@virtuousgeek.org \
    --cc=ink@jurassic.park.msu.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=mingo@elte.hu \
    --cc=torvalds@linux-foundation.org \
    --cc=yhlu.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®