mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: Robert Hancock <hancockrwd@gmail.com>,
	"linux-kernel" <linux-kernel@vger.kernel.org>,
	ide <linux-ide@vger.kernel.org>, Jeff Garzik <jgarzik@pobox.com>
Subject: Re: [PATCH] libata: remove experimental tag on PATA drivers
Date: Fri, 13 Nov 2009 21:30:07 +0000	[thread overview]
Message-ID: <20091113213007.774e75e3@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <200911132039.06929.bzolnier@gmail.com>

> > Not experimental as we default to not doing ATAPI DMA. Glancing over the
> 
> Which is a regression compared to the "old IDE" driver.

And given the two drivers show the difference when exactly the sequence
of I/O writes/reads occurs one that nobody plans to worry about as its
clearly some kind of hardware timing issue.

> > code I notice the ALI C2/C3 workaround probably wants adding to the old
> > driver as it can do nasty things otherwise. (See the reset function in
> > the pata_ali driver)
> 
> Please let the driver's maintainer know about it.
> 
> One would wonder why workaround hasn't been back-ported to stable driver

It's in the stable driver, might not be in drivers/ide. The note about it
being missing was posted out to various people at the time so I guess it
got missed

> > > PATA_CMD64X: EXPERIMENTAL
> > > - potential data corruption issues remains unfixed for CMD64[3,6]
> > 
> > Patch in testing, and unlike the old IDE one it doesn't cripple the
> > controller but implements the proper workaround in full including
> > permitting parallel PIO command streams. I'll push that back through
> > stable once done.
> 
> This patch is way too complex and risky for -rc, let alone -stable.

How would you know - I've not posted it yet ? And btw I don't plan to
post it for the -rc. Nor would simply posting a serializing hack fix it.
It might make it less likely to occur but that isn't a fix.

> > it. Trivial and fixed.
> 
> I can't see a fix anywhere but I'll assume that I can't look for it
> properly (I'm really sorry for it).

Fixed as in I fixed it now. Which is why I just noticed the old IDE ones
are buggy. I'll add it to the next patch sets for Jeff, along with the
Toshiba driver and some other bits.

Alan



  reply	other threads:[~2009-11-13 21:28 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-13  2:13 Robert Hancock
2009-11-13 11:07 ` Alan Cox
2009-11-13 16:15 ` Bartlomiej Zolnierkiewicz
2009-11-13 18:25   ` Alan Cox
2009-11-13 19:39     ` Bartlomiej Zolnierkiewicz
2009-11-13 21:30       ` Alan Cox [this message]
2009-11-13 22:17         ` Bartlomiej Zolnierkiewicz
2009-11-13 22:42           ` Alan Cox
2009-11-13 22:58             ` Bartlomiej Zolnierkiewicz
2009-11-14  0:03               ` Alan Cox
2009-11-13 21:57       ` Jeff Garzik
2009-11-13 22:24         ` Bartlomiej Zolnierkiewicz
2009-11-13 22:26     ` Alejandro Riveira Fernández
2009-11-13 23:46     ` Bartlomiej Zolnierkiewicz
2009-11-14  0:14       ` Bartlomiej Zolnierkiewicz
2009-11-14  0:15       ` Alan Cox
2009-11-14  1:08         ` Bartlomiej Zolnierkiewicz
2009-11-14 16:04           ` Alan Cox
2009-11-14 16:59             ` Bartlomiej Zolnierkiewicz
2009-11-14  2:29       ` Matthew Garrett
2009-11-14  2:54         ` Bartlomiej Zolnierkiewicz
2009-11-14 12:02           ` Bartlomiej Zolnierkiewicz
2009-11-17  3:18 ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091113213007.774e75e3@lxorguk.ukuu.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=bzolnier@gmail.com \
    --cc=hancockrwd@gmail.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®