mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Roland McGrath <roland@redhat.com>
To: Masami Hiramatsu <mhiramat@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>, lkml <linux-kernel@vger.kernel.org>,
	systemtap <systemtap@sources.redhat.com>,
	DLE <dle-develop@lists.sourceforge.net>,
	Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Oleg Nesterov <oleg@redhat.com>
Subject: Re: [PATCH -tip 1/3] Pass mm->flags to binfmt core_dump for bitflag consistency
Date: Fri, 13 Nov 2009 15:16:02 -0800 (PST)	[thread overview]
Message-ID: <20091113231602.2DD2C100E@magilla.sf.frob.com> (raw)
In-Reply-To: Masami Hiramatsu's message of  Friday, 13 November 2009 17:52:27 -0500 <20091113225226.15079.90813.stgit@harusame>

To clarify, proc_coredump_filter_write() is the one place that can change
mm->flags during a core dump.  I don't think any other is possible while
all the other tasks sharing that mm are prevented from running.  Is there
any other way that mm->flags might change during do_coredump()?

I don't see anything wrong with this change.  But (assuming that is the
only case), there is another approach we could take instead.  That is,
have proc_coredump_filter_write() do:

	down_read(&mm->mmap_sem);
	ret = mm->core_state ? -EBUSY : 0;
	up_read(&mm->mmap_sem);


Thanks,
Roland

  parent reply	other threads:[~2009-11-13 23:16 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-13 22:52 Masami Hiramatsu
2009-11-13 22:52 ` [PATCH -tip 2/3] Add coredump tracepoint Masami Hiramatsu
2009-11-13 23:39   ` Roland McGrath
2009-11-14  0:00     ` Masami Hiramatsu
2009-11-14  0:02     ` Ingo Molnar
2009-11-14  0:06       ` Roland McGrath
2009-11-14  0:14         ` Ingo Molnar
2009-11-14  1:49           ` Roland McGrath
2009-11-14  0:25         ` Masami Hiramatsu
2009-11-13 22:52 ` [PATCH -tip 3/3] Add get_signal tracepoint Masami Hiramatsu
2009-11-13 23:53   ` Roland McGrath
2009-11-14  0:10     ` Ingo Molnar
2009-11-16 21:51       ` Masami Hiramatsu
2009-11-16 22:09         ` Roland McGrath
2009-11-16 22:39           ` Masami Hiramatsu
2009-11-16 23:00             ` Roland McGrath
2009-11-16 23:45               ` Masami Hiramatsu
2009-11-17  6:01         ` Ingo Molnar
2009-11-17 15:26           ` Masami Hiramatsu
2009-11-14  0:29     ` Masami Hiramatsu
2009-11-13 23:09 ` [PATCH -tip 1/3] Pass mm->flags to binfmt core_dump for bitflag consistency Andrew Morton
2009-11-13 23:24   ` Ingo Molnar
2009-11-13 23:44     ` Masami Hiramatsu
2009-11-13 23:16 ` Roland McGrath [this message]
2009-11-13 23:23   ` Ingo Molnar
2009-11-13 23:29     ` Roland McGrath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091113231602.2DD2C100E@magilla.sf.frob.com \
    --to=roland@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=dle-develop@lists.sourceforge.net \
    --cc=hidehiro.kawai.ez@hitachi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@redhat.com \
    --cc=mingo@elte.hu \
    --cc=oleg@redhat.com \
    --cc=systemtap@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®