From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1752293AbZKOIjx@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752293AbZKOIjx (ORCPT <rfc822;w@1wt.eu>);
	Sun, 15 Nov 2009 03:39:53 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752143AbZKOIjw
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Sun, 15 Nov 2009 03:39:52 -0500
Received: from mx3.mail.elte.hu ([157.181.1.138]:49695 "EHLO mx3.mail.elte.hu"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752130AbZKOIjv (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sun, 15 Nov 2009 03:39:51 -0500
Date: Sun, 15 Nov 2009 09:39:51 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Joe Perches <joe@perches.com>
Cc: Am??rico Wang <xiyou.wangcong@gmail.com>,
       "Eric W. Biederman" <ebiederm@xmission.com>,
       LKML <linux-kernel@vger.kernel.org>,
       Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] sysctl.c: Change a .proc_handler = proc_dointvec to
 &proc_dointvec,
Message-ID: <20091115083951.GA27393@elte.hu>
References: <1258249925.16857.198.camel@Joe-Laptop.home>
 <20091115065958.GA2459@hack>
 <20091115081126.GD15432@elte.hu>
 <1258273714.21668.13.camel@Joe-Laptop.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1258273714.21668.13.camel@Joe-Laptop.home>
User-Agent: Mutt/1.5.20 (2009-08-17)
X-ELTE-SpamScore: -2.0
X-ELTE-SpamLevel: 
X-ELTE-SpamCheck: no
X-ELTE-SpamVersion: ELTE 2.0 
X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.5
	-2.0 BAYES_00               BODY: Bayesian spam probability is 0 to 1%
	[score: 0.0000]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Joe Perches <joe@perches.com> wrote:

> On Sun, 2009-11-15 at 09:11 +0100, Ingo Molnar wrote:
> > * Am??rico Wang <xiyou.wangcong@gmail.com> wrote:
> > > On Sat, Nov 14, 2009 at 05:52:05PM -0800, Joe Perches wrote:
> > > >Seems to be a typo.
> > > Acked-by: WANG Cong <xiyou.wangcong@gmail.com>
> > (Cc:-ed Eric who is running the sysctl tree these days)
> > Almost everywhere in the kernel we use the shorter version, so all of 
> > sysctl.c should eventually change to that variant.
> 
> It's closer to 50/50, but it's 1 vs 133 in that file.
> 
> $ grep -Pr --include=*.[ch] '\.proc_handler\s*=\s*&\s*\w+' * | wc -l
> 339
> 
> $ grep -Pr --include=*.[ch] '\.proc_handler\s*=\s*[^&]\s*\w+' * | wc -l
> 432

I did not mean this specific initialization method of proc_handler, i 
meant pointers to functions in general.

	Ingo