From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: Alan Cox <alan@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH 3/5] cmd64x: implement serialization as per notes
Date: Tue, 17 Nov 2009 18:08:18 +0000 [thread overview]
Message-ID: <20091117180818.0ed9ace4@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <200911171835.05232.bzolnier@gmail.com>
On Tue, 17 Nov 2009 18:35:05 +0100
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote:
> On Tuesday 17 November 2009 15:51:32 Alan Cox wrote:
>
> > +struct cmd_priv
> > +{
> > + int dma_live; /* Channel using DMA */
> > + int irq_t[2]; /* Register to check for IRQ */
> > + int irq_m[2]; /* Bit to check */
> > +};
>
> irq_t and irq_m content will be identical for all host instances
Once I've had a look at the later chip variants I'll indeed do that
providing the 648 is ok in all revs.
> so you may as well add one instance for it, use ->private_data to
> store dma_live information and remove cmd_priv allocation
>
> > + /* If the other port is not live then issue the command */
> > + if (alt == NULL || !alt->qc_active) {
> > + if (dma)
> > + priv->dma_live = qc->ap->port_no;
> > + return 0;
> > + }
> > + /* If there is a live DMA command then wait */
> > + if (priv->dma_live != -1)
> > + return ATA_DEFER_PORT;
> > + if (dma) {
> > + /* Cannot overlap our DMA command */
> > + if (alt->qc_active)
> > + return ATA_DEFER_PORT;
>
> no need to check alt->qc_active again here
Good point
Thanks for the review.
next prev parent reply other threads:[~2009-11-17 18:06 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-17 14:50 [PATCH 0/5] Series short description Alan Cox
2009-11-17 14:51 ` [PATCH 1/5] pata_via: Blacklist some combinations of Transcend Flash and via Alan Cox
2009-11-17 14:51 ` [PATCH 2/5] pata_sis: Implement MWDMA for the UDMA 133 capable chips Alan Cox
2009-11-17 17:27 ` Bartlomiej Zolnierkiewicz
2009-11-17 17:38 ` Alan Cox
2009-11-17 17:57 ` Bartlomiej Zolnierkiewicz
2009-11-17 18:21 ` Alan Cox
2009-11-17 19:33 ` Bartlomiej Zolnierkiewicz
2009-11-17 14:51 ` [PATCH 3/5] cmd64x: implement serialization as per notes Alan Cox
2009-11-17 17:35 ` Bartlomiej Zolnierkiewicz
2009-11-17 18:08 ` Alan Cox [this message]
2009-11-17 14:51 ` [PATCH 4/5] pata: Update experimental tags Alan Cox
2009-11-17 22:36 ` Jeff Garzik
2009-11-18 18:19 ` Bartlomiej Zolnierkiewicz
2009-11-18 18:41 ` Alan Cox
2009-11-18 18:47 ` Sergei Shtylyov
2009-11-18 19:16 ` Bartlomiej Zolnierkiewicz
2009-11-18 19:07 ` Bartlomiej Zolnierkiewicz
2009-11-18 19:56 ` Bartlomiej Zolnierkiewicz
2009-11-19 13:16 ` Alan Cox
2009-11-19 14:17 ` Bartlomiej Zolnierkiewicz
2009-11-19 14:33 ` Alan Cox
2009-11-19 14:50 ` Bartlomiej Zolnierkiewicz
2009-11-19 15:16 ` Bartlomiej Zolnierkiewicz
2009-11-19 15:24 ` Alan Cox
2009-11-19 15:22 ` Alan Cox
2009-11-19 15:45 ` Bartlomiej Zolnierkiewicz
2009-11-19 16:27 ` Alan Cox
2009-11-19 17:10 ` Bartlomiej Zolnierkiewicz
2009-11-19 17:38 ` Bartlomiej Zolnierkiewicz
2009-11-19 17:50 ` Alan Cox
2009-11-19 17:52 ` Bartlomiej Zolnierkiewicz
2009-11-19 18:21 ` Alan Cox
2009-11-19 18:38 ` Sergei Shtylyov
2009-11-19 19:03 ` Bartlomiej Zolnierkiewicz
2009-11-19 19:31 ` Bartlomiej Zolnierkiewicz
2009-11-19 19:42 ` Alan Cox
2009-11-19 19:54 ` Bartlomiej Zolnierkiewicz
2009-11-19 21:34 ` Jeff Garzik
2009-11-19 21:49 ` Jeff Garzik
2009-11-19 19:40 ` Alan Cox
2009-11-19 21:21 ` Sergei Shtylyov
2009-11-20 18:20 ` Sergei Shtylyov
2009-11-19 18:58 ` Bartlomiej Zolnierkiewicz
2009-11-19 21:48 ` Jeff Garzik
2009-11-19 14:02 ` Alan Cox
2009-11-19 14:16 ` Sergei Shtylyov
2009-11-19 14:31 ` Alan Cox
2009-11-19 14:38 ` Sergei Shtylyov
2009-11-19 14:22 ` Bartlomiej Zolnierkiewicz
2009-11-19 21:38 ` Jeff Garzik
2009-11-19 21:49 ` Bartlomiej Zolnierkiewicz
2009-11-19 22:03 ` Jeff Garzik
2009-11-20 21:17 ` Bartlomiej Zolnierkiewicz
2009-11-19 23:42 ` Alan Cox
2009-11-18 19:34 ` Bartlomiej Zolnierkiewicz
2009-11-18 19:59 ` Bartlomiej Zolnierkiewicz
2009-11-19 21:36 ` Jeff Garzik
2009-11-19 21:42 ` Bartlomiej Zolnierkiewicz
2009-11-19 21:57 ` Jeff Garzik
2009-11-19 23:38 ` Alan Cox
2009-11-17 14:52 ` [PATCH 5/5] pata_piccolo: Driver for old Toshiba chipsets Alan Cox
2009-11-27 14:28 ` Bartlomiej Zolnierkiewicz
2009-11-27 15:34 ` Alan Cox
2009-11-19 21:41 ` [PATCH 0/5] Series short description Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091117180818.0ed9ace4@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=alan@linux.intel.com \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®