From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Michael Buesch <mb@bu3sch.de>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] strcmp: fix overflow error
Date: Tue, 17 Nov 2009 19:55:39 +0100 [thread overview]
Message-ID: <20091117185539.GA23385@pengutronix.de> (raw)
In-Reply-To: <alpine.LFD.2.01.0911170922190.9384@localhost.localdomain>
Hello Linus,
On Tue, Nov 17, 2009 at 09:41:58AM -0800, Linus Torvalds wrote:
> On Tue, 17 Nov 2009, Uwe Kleine-König wrote:
> >
> > strcmp("\x01", "\xef") returns 18 but it should return something < 0.
> > The reason is that the variable holding the result of the subtraction is
> > too small and overflows.
>
> No. The reason is that whoever wrote that function is a moron and doesn't
> know the standard. And your fix is not correct _either_
OK, right.
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
(BTW, this was already broken in 2.4.0, so I was unable to find out who
is the moron :-)
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2009-11-17 18:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-17 16:51 Uwe Kleine-König
2009-11-17 17:36 ` Andreas Schwab
2009-11-17 17:41 ` Linus Torvalds
2009-11-17 18:16 ` Michael Buesch
2009-11-17 18:40 ` Linus Torvalds
2009-11-17 20:34 ` Andreas Schwab
2009-11-17 18:55 ` Uwe Kleine-König [this message]
2009-11-17 19:02 ` Linus Torvalds
2009-11-17 19:12 ` Linus Torvalds
2009-11-17 19:19 ` Joe Perches
2009-11-18 21:31 ` [PATCH] strcmp: fix overflow and possibly signedness error Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091117185539.GA23385@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mb@bu3sch.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®