mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjan@infradead.org>
To: tglx@linutronix.de
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org, peterz@infradead.org
Subject: commit b00bc0b237055b breaking perf subsystem
Date: Thu, 19 Nov 2009 11:50:20 -0800	[thread overview]
Message-ID: <20091119115020.7bd8896b@infradead.org> (raw)


commit b00bc0b237055b4c45816325ee14f0bd83e6f590
Author: Thomas Gleixner <tglx@linutronix.de>
Date:   Mon Nov 2 13:01:56 2009 +0100

    uids: Prevent tear down race

has been bisected to break the perf system between -rc5 and -rc7;
and reverting this patch in rc7 also fixes the issue.

now this patch is.... fun and seemingly unrelated to perf, so I
am pretty sure something else is going on.

the symptom of the breakage is that a userland client of perf
(in my case, powertop) does not get to see new events if there
is only, say, one or two of them. The data_head pointer just does
not get updated.

Based on the patch, I have a suspicion that this pointer gets updated
from synchronize RCU context, and this patch just makes that happen
more.

If that is the case, what we really need is a new ioctl to perf that
will cause all pending buffer state to be flushed to the ring buffer,
that applications using perf can then just always call before looking
at the ring. As a concept, that sounds like a good idea to me anyway...

comments/suggestions/saying-I'm-full-of-sh*t ?



-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org

             reply	other threads:[~2009-11-19 19:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-19 19:50 Arjan van de Ven [this message]
2009-11-19 20:02 ` Peter Zijlstra
2009-11-19 20:24 ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091119115020.7bd8896b@infradead.org \
    --to=arjan@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®