mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	hpa@zytor.com, alan@lxorguk.ukuu.org.uk, mgarski@post.pl
Subject: Re: [PATCH] kbd: (#7063) make CapsLock work as expected even for non-ASCII
Date: Thu, 19 Nov 2009 14:28:28 +0100	[thread overview]
Message-ID: <20091119132828.GA31025@const.bordeaux.inria.fr> (raw)
In-Reply-To: <20091119131854.GA1628@x200.localdomain>

Alexey Dobriyan, le Thu 19 Nov 2009 16:18:54 +0300, a écrit :
> > More precisely, in the kbd source code, in the add_capslock function, in
> > the unicode case, instead of ignoring the '+', add 0xD800 to the unicode
> > value if it is below 0x0800.
> 
> You suggest to change kernel and keymap and kbd and introduce 0xD800 hack.
> This is not going to fly.

Sure, that's precisely what I said here:

> > But again, that's a very limited fix and just fixing the LED interface
> > would allow to just use modifiers and permit much more powerful keymaps.

Just to make sure you understand my point: your bug is _not_ in the
kernel, but in kbd, see what the add_capslock() function does when in
unicode mode:

	fprintf(stderr, _("plus before %s ignored\n"), p);

No wonder capslocked keys don't work, kbd doesn't even tell the kernel
which keys should get capslock behavior. Breaking the capslock behavior
to make it a shiftlock to compensate kbd's bug is not going to fly
either.

Now, as I said, kbd's issue is that it doesn't have any way to express
that a unicode keysym should get capslock behavior, due to kernel
interface limitation.  But as I said, it can do like console-setup: use
a modifier instead of the limited capslock interface. A side issue is
that modifier locks don't get advertised through keyboard leds. That can
be solved by adding an interface to make that happen.

Instead of breaking an interface (capslock by making it a shiftlock
instead), add one that makes sense (being able to configure how modifier
locks are advertised through LEDs). _That_ will fly.

Samuel

  reply	other threads:[~2009-11-19 13:28 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-16 13:51 Alexey Dobriyan
2009-11-16 14:40 ` Alan Cox
2009-11-16 19:08   ` Samuel Thibault
2009-11-16 19:07 ` Samuel Thibault
2009-11-16 19:53   ` Alexey Dobriyan
2009-11-16 22:27     ` Samuel Thibault
2009-11-16 22:53       ` Alexey Dobriyan
2009-11-16 23:04         ` Samuel Thibault
2009-11-16 22:54       ` Samuel Thibault
2009-11-16 23:05         ` Alexey Dobriyan
2009-11-16 23:15           ` Samuel Thibault
2009-11-17 11:55             ` Alexey Dobriyan
2009-11-17 13:23               ` Samuel Thibault
2009-11-19 13:18                 ` Alexey Dobriyan
2009-11-19 13:28                   ` Samuel Thibault [this message]
2009-11-19 13:37                     ` Samuel Thibault
2009-11-19 15:07                       ` H. Peter Anvin
2009-11-20 19:07                         ` Pavel Machek
2009-11-20 20:46                           ` Pavel Machek
2009-11-20 21:27                             ` H. Peter Anvin
2010-02-21  5:01                               ` [RFC,PATCH] Route kbd leds through the generic leds layer (Was: [PATCH] kbd: (#7063) make CapsLock work as expected even for non-ASCII) Samuel Thibault
2010-02-23 16:30                                 ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091119132828.GA31025@const.bordeaux.inria.fr \
    --to=samuel.thibault@ens-lyon.org \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgarski@post.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®