From: Alexey Dobriyan <adobriyan@gmail.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
akpm@linux-foundation.org, tglx@linutronix.de
Subject: Re: [tip:irq/core] genirq: switch /proc/irq/*/spurious to seq_file
Date: Thu, 19 Nov 2009 21:50:56 +0300 [thread overview]
Message-ID: <20091119185056.GA29223@x200.localdomain> (raw)
In-Reply-To: <tip-a1afb6371bb5341057056194d1168753f6d77242@git.kernel.org>
On Wed, Nov 18, 2009 at 11:54:34AM +0000, tip-bot for Alexey Dobriyan wrote:
> --- a/kernel/irq/proc.c
> +++ b/kernel/irq/proc.c
> @@ -148,18 +148,28 @@ static const struct file_operations default_affinity_proc_fops = {
> };
> #endif
>
> -static int irq_spurious_read(char *page, char **start, off_t off,
> - int count, int *eof, void *data)
> +static int irq_spurious_proc_show(struct seq_file *m, void *v)
> {
> - struct irq_desc *desc = irq_to_desc((long) data);
> - return sprintf(page, "count %u\n"
> - "unhandled %u\n"
> - "last_unhandled %u ms\n",
> - desc->irq_count,
> - desc->irqs_unhandled,
> - jiffies_to_msecs(desc->last_unhandled));
> + struct irq_desc *desc = irq_to_desc((long) m->private);
^^^^^^^^^^
> +
> + seq_printf(m, "count %u\n" "unhandled %u\n" "last_unhandled %u ms\n",
> + desc->irq_count, desc->irqs_unhandled,
> + jiffies_to_msecs(desc->last_unhandled));
> + return 0;
> +}
> +
> +static int irq_spurious_proc_open(struct inode *inode, struct file *file)
> +{
> + return single_open(file, irq_spurious_proc_show, NULL);
Oops, there has to be PDE(inode)->data instead of NULL.
next prev parent reply other threads:[~2009-11-19 18:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-28 18:19 [PATCH] " Alexey Dobriyan
2009-11-18 11:54 ` [tip:irq/core] " tip-bot for Alexey Dobriyan
2009-11-19 18:50 ` Alexey Dobriyan [this message]
2009-11-20 10:19 ` Ingo Molnar
2009-11-20 11:23 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091119185056.GA29223@x200.localdomain \
--to=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®