mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: Wu Zhangjin <wuzhangjin@gmail.com>,
	Ralf Baechle <ralf@linux-mips.org>,
	linux-mips@linux-mips.org, Thomas Gleixner <tglx@linutronix.de>,
	Michal Simek <monstr@monstr.eu>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] MIPS: Add a high resolution sched_clock() via cnt32_to_63().
Date: Sun, 22 Nov 2009 19:06:16 +0100	[thread overview]
Message-ID: <20091122180616.GB24711@elte.hu> (raw)
In-Reply-To: <4B0925BD.6070507@ru.mvista.com>


* Sergei Shtylyov <sshtylyov@ru.mvista.com> wrote:

> Hello.
> 
> Ingo Molnar wrote:
> 
> >>+config HR_SCHED_CLOCK
> >>+	bool "High Resolution sched_clock()"
> >>+	depends on CSRC_R4K
> >>+	default n
> >>+	help
> >>+	  This option enables the MIPS c0 count based high resolution
> >>+	  sched_clock().
> >>+
> >>+	  If you need a ns precision timestamp, You are recommended to enable
> >>+	  this option. For example, If you are using the Ftrace subsystem to do
> 
>   s/If/if/
> 
> >>diff --git a/arch/mips/kernel/csrc-r4k.c b/arch/mips/kernel/csrc-r4k.c
> >>index e95a3cd..4e52cca 100644
> >>--- a/arch/mips/kernel/csrc-r4k.c
> >>+++ b/arch/mips/kernel/csrc-r4k.c
> >>@@ -6,10 +6,64 @@
> >>  * Copyright (C) 2007 by Ralf Baechle
> >>  */
> >> #include <linux/clocksource.h>
> >>+#include <linux/cnt32_to_63.h>
> >>+#include <linux/timer.h>
> >> #include <linux/init.h>
> >> #include <asm/time.h>
> >>+/*
> >>+ * MIPS' sched_clock implementation.
> >
> >s/MIPS'/MIPS's
> 
>   MIPS's is not really a proper English. :-)

AFAIK 'MIPS' is not the plural of 'MIP' (but an acronym ending with 
'S'), hence the possessive form would be MIPS's.

It doesnt matter much i guess ;-)

	Ingo

  reply	other threads:[~2009-11-22 18:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-22  7:44 Wu Zhangjin
2009-11-22  8:13 ` Ingo Molnar
2009-11-22 11:08   ` Wu Zhangjin
2009-11-22 11:55     ` Sergei Shtylyov
2009-11-22 12:35     ` Ralf Baechle
2009-11-22 13:18       ` Wu Zhangjin
2009-11-22 11:51   ` Sergei Shtylyov
2009-11-22 18:06     ` Ingo Molnar [this message]
2009-11-22 20:23       ` Ralf Baechle
2009-11-23  8:42         ` Ingo Molnar
2009-12-02  1:58           ` Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091122180616.GB24711@elte.hu \
    --to=mingo@elte.hu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=monstr@monstr.eu \
    --cc=ralf@linux-mips.org \
    --cc=sshtylyov@ru.mvista.com \
    --cc=tglx@linutronix.de \
    --cc=wuzhangjin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®