mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Ingo Molnar <mingo@elte.hu>
Cc: Mike Galbraith <efault@gmx.de>, Robert Swan <swan.r.l@gmail.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [bisected] pty performance problem
Date: Mon, 23 Nov 2009 13:34:23 +0000	[thread overview]
Message-ID: <20091123133423.64f34c73@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20091123120409.GA32009@elte.hu>

> > So you'd prefer to detect devices that are byte based or message based 
> > by what method ?
> 
> I'd not delay the worklet by default - i.e. i'd do Mike's patch.

Certainly stuff like pty should not delay
> 
> Havent tested all effects of it though - do you have any estimation 
> about negative effects from such a change? We do have hard numbers 
> (latencies in the millisecs range) from the opposite direction and those 
> numbers arent pretty.

On a PC I'm not too worried - we might burn a bit more CPU and Arjan
might even manage to measure it somewhere. There is the theoretical bad
case where we end up at 100% CPU because the irq, wake, process one char,
irq wake, process one char sequence fits the CPU so we don't sleep.

Embedded might be more of a concern, the old behaviour comes from 386/486
days with low CPU power.

USB doesn't worry me - USB devices generally have their own buffering
algorithm and use a timer so that they batch data efficiently into USB
buffers.

The drivers/serial layer is often run with low latency set anyway so that
seems to be ok for the most part.

Give it a go, send the patch to the maintainer, try it in -next and see
if anyone screams.

Alan

  reply	other threads:[~2009-11-23 13:32 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-21 22:23 Robert Swan
2009-11-21 23:23 ` Alan Cox
2009-11-22  0:27   ` Robert Swan
2009-11-22 12:29     ` Alan Cox
2009-11-22 12:41       ` Mike Galbraith
2009-11-22 21:37       ` Robert Swan
2009-11-22  6:39 ` Ingo Molnar
2009-11-22  7:15   ` Arjan van de Ven
2009-11-22 21:56     ` Robert Swan
2009-11-22 12:23   ` Alan Cox
2009-11-22 12:42     ` Ingo Molnar
2009-11-23  5:00     ` Mike Galbraith
2009-11-23 10:28       ` Alan Cox
2009-11-23 11:31       ` Alan Cox
2009-11-23 11:48         ` Ingo Molnar
2009-11-23 11:59           ` Alan Cox
2009-11-23 12:04             ` Ingo Molnar
2009-11-23 13:34               ` Alan Cox [this message]
2009-11-23 17:48                 ` Ingo Molnar
2011-07-09  6:29 ` Robert Swan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091123133423.64f34c73@lxorguk.ukuu.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=efault@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=swan.r.l@gmail.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®