From: Andrew Morton <akpm@linux-foundation.org>
To: Alek Du <alek.du@intel.com>
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>,
David Brownell <david-b@pacbell.net>
Subject: Re: [PATCH] gpio: Langwell GPIO driver miscellaneous clean-ups
Date: Tue, 24 Nov 2009 12:29:37 -0800 [thread overview]
Message-ID: <20091124122937.ac9371d0.akpm@linux-foundation.org> (raw)
In-Reply-To: <20091122111901.5e99a391@dxy.sh.intel.com>
On Sun, 22 Nov 2009 11:19:01 +0800
Alek Du <alek.du@intel.com> wrote:
> >From 9ba8224f5246ef7fdf1c0a15bb5535e442731435 Mon Sep 17 00:00:00 2001
> From: Alek Du <alek.du@intel.com>
> Date: Sun, 22 Nov 2009 10:58:21 +0800
> Subject: [PATCH] gpio: Langwell GPIO driver miscellaneous clean-ups
>
> 1. Use >= N to check invalid gpio number (unsigned type)
I already had this in gpio-fix-test-on-unsigned-in-lnw_irq_type.patch
> 2. Remove wrong and unnecessary unmask operation
> 3. Remove extra GEDR reading
>
> The 2) and 3) will fix interrupts losing when two or more pins are triggered at close time.
>
Those aren't cleanups - they're bug fixes!
How important are they?
next prev parent reply other threads:[~2009-11-24 20:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-22 3:19 Alek Du
2009-11-24 20:29 ` Andrew Morton [this message]
2009-11-25 1:02 ` Alek Du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091124122937.ac9371d0.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alek.du@intel.com \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®