mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: John Kacur <jkacur@redhat.com>
Cc: linux-kernel@vger.kernel.org,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	acme@redhat.com
Subject: Re: [PATCH] Perf-tools create common process_event functions
Date: Tue, 24 Nov 2009 16:32:59 +0100	[thread overview]
Message-ID: <20091124153259.GE21821@elte.hu> (raw)
In-Reply-To: <1259073301-11506-1-git-send-email-jkacur@redhat.com>


* John Kacur <jkacur@redhat.com> wrote:

> This continues the effort to prevent bit-rot in perf-annotate by using
> common functions for perf-report and perf-annotate where possible.
> 
> This creates the process.[ch] files.
> More functions can be added here after - but this is a working step
> in the process.
> 
> John Kacur (2):
>   perf-tools: Add perf.data to .gitignore
>   perf-tools: Use common process_event functions for annotate and
>     report
> 
>  tools/perf/.gitignore            |    1 +
>  tools/perf/Makefile              |    2 +
>  tools/perf/builtin-annotate.c    |   56 +--------------------------------
>  tools/perf/builtin-report.c      |   63 +------------------------------------
>  tools/perf/util/process_event.c  |   53 +++++++++++++++++++++++++++++++
>  tools/perf/util/process_event.h  |   29 +++++++++++++++++
>  tools/perf/util/process_events.c |   64 ++++++++++++++++++++++++++++++++++++++
>  tools/perf/util/process_events.h |   35 ++++++++++++++++++++
>  8 files changed, 187 insertions(+), 116 deletions(-)
>  create mode 100644 tools/perf/util/process_event.c
>  create mode 100644 tools/perf/util/process_event.h
>  create mode 100644 tools/perf/util/process_events.c
>  create mode 100644 tools/perf/util/process_events.h

Nice cleanups, applied to tip:perf/core, thanks John!

	Ingo

      parent reply	other threads:[~2009-11-24 15:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-24 14:34 John Kacur
2009-11-24 14:35 ` [PATCH] perf-tools: Add perf.data to .gitignore John Kacur
2009-11-24 14:35   ` [PATCH] perf-tools: Use common process_event functions for annotate and report John Kacur
2009-11-24 16:57     ` [tip:perf/core] perf tools: " tip-bot for John Kacur
2009-11-24 16:57   ` [tip:perf/core] perf tools: Add perf.data to .gitignore tip-bot for John Kacur
2009-11-24 15:32 ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091124153259.GE21821@elte.hu \
    --to=mingo@elte.hu \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=jkacur@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®