mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: "Youquan,Song" <youquan.song@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, ying.huang@intel.com,
	kent.liu@intel.com, youquan.song@intel.com
Subject: Re: [PATCH]crypto: Fix aesni algorithm implementation without test
Date: Thu, 26 Nov 2009 08:13:23 +0800	[thread overview]
Message-ID: <20091126001323.GA1193@gondor.apana.org.au> (raw)
In-Reply-To: <20091126004226.GA32230@youquan-linux.bj.intel.com>

On Wed, Nov 25, 2009 at 07:42:27PM -0500, Youquan,Song wrote:
> when load aesni-intel driver,kernel will report no test for some algorithm
> with AES-NI. The strange information as following:
> 
> alg: No test for __aes-aesni (__driver-aes-aesni)
> alg: No test for __ecb-aes-aesni (__driver-ecb-aes-aesni)
> alg: No test for __cbc-aes-aesni (__driver-cbc-aes-aesni)
> alg: No test for __ecb-aes-aesni (cryptd(__driver-ecb-aes-aesni)
> 
> crypto_alg's cra_name is use to descript algorithm itself, do not care the 
> concrete implement. So this patch unify them and also can fix the algorithm
> implementation without test. 
> 
> Signed-off-by: Youquan, Song <youquan.song@intel.com>

No this is bogus.  The algorithm name is specifically set to these
values because they're not meant to be used directly by anyone other
than aesni.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

      reply	other threads:[~2009-11-26  0:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-26  0:42 Youquan,Song
2009-11-26  0:13 ` Herbert Xu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091126001323.GA1193@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=kent.liu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ying.huang@intel.com \
    --cc=youquan.song@intel.com \
    --cc=youquan.song@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®