mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Youquan,Song" <youquan.song@linux.intel.com>
To: herbert@gondor.apana.org.au
Cc: linux-kernel@vger.kernel.org, ying.huang@intel.com,
	kent.liu@intel.com, youquan.song@intel.com
Subject: [PATCH]crypto: Fix ghash pclmulqdqni algorithm without test
Date: Wed, 25 Nov 2009 19:46:33 -0500	[thread overview]
Message-ID: <20091126004633.GB32230@youquan-linux.bj.intel.com> (raw)

when load ghash-clmulni-intel driver,kernel will report no test for some algorithm
with PCLMULQDQ NI. The strange information as following:

alg: No test for __ghash (__ghash-pclmulqdqni)
alg: No test for __ghash (cryptd(__ghash-pclmulqdqni))

crypto_alg's cra_name is use to descript algorithm itself, do not care the 
concrete implement. So this patch unify them and also can fix the algorithm
implementation without test. 

Signed-off-by: Youquan, Song <youquan.song@intel.com>
---

diff --git a/arch/x86/crypto/ghash-clmulni-intel_glue.c b/arch/x86/crypto/ghash-clmulni-intel_glue.c
index cbcc8d8..3fab6cb 100644
--- a/arch/x86/crypto/ghash-clmulni-intel_glue.c
+++ b/arch/x86/crypto/ghash-clmulni-intel_glue.c
@@ -141,7 +141,7 @@ static struct shash_alg ghash_alg = {
 	.setkey		= ghash_setkey,
 	.descsize	= sizeof(struct ghash_desc_ctx),
 	.base		= {
-		.cra_name		= "__ghash",
+		.cra_name		= "ghash",
 		.cra_driver_name	= "__ghash-pclmulqdqni",
 		.cra_priority		= 0,
 		.cra_flags		= CRYPTO_ALG_TYPE_SHASH,

             reply	other threads:[~2009-11-25 17:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-26  0:46 Youquan,Song [this message]
2009-11-26  0:14 ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091126004633.GB32230@youquan-linux.bj.intel.com \
    --to=youquan.song@linux.intel.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=kent.liu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ying.huang@intel.com \
    --cc=youquan.song@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome