Re: keyboard leds not restored after s2ram in 2.6.32-rc6-00166-g799dd75

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

On Thu, Nov 12, 2009 at 12:08:39AM -0800, Mikko Vinni wrote:
> From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> 
> > > I did some tests suspending with the caps lock actually on, and it seems that
> > > in that case the user might still be confused (caps lock is on but led is 
> > off).
> > > At least on this machine this patch doesn't affect this theoretical problem
> > > either way (2.6.31 behaves similarly), so it is ok.
> > > 
> > 
> > Umm... so you are saying that even with .31 if you suspend with capslock
> > on it is off when you resume? Does it happen only in X or in console as
> > well?
> 
> It seems I judged a bit too early.
> In console, both 2.6.31 and .32-rc6+your patch:
> - suspending both with capslock on and off works as expected (same state in mode
> and led after resume)
> 
> In X, both  2.6.31 and .32-rc6+your patch:
> - suspending both with capslock on and off works; after resume same state
> (typing procudes capital letters if capslock was on) and led shows the caplock
> state
> - if the capslock is on after resume, and I press shift before capslock key, the led
> turns off but typing still produces capital letters. This, I think, is strange. This did
> not happen in console, neither does pressing shift usually turn off the led.
> 
> So, apart from the minor nuisance of the shift key turning off the capslock led in X
> even if typing still produces capital letters, everything seems to work as expected.
> 

OK, so from this description it looks like an issue in X, not in the
kernel.


Thanks.

-- 
Dmitry