From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: John Ogness <john.ogness@linutronix.de>
Cc: Sascha Hauer <kernel@pengutronix.de>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MXC: set GPIO IRQ handler
Date: Thu, 26 Nov 2009 08:57:24 +0100 [thread overview]
Message-ID: <20091126075724.GA12179@pengutronix.de> (raw)
In-Reply-To: <807htelb5d.fsf@merkur.tec.linutronix.de>
Hello John,
On Wed, Nov 25, 2009 at 07:19:58PM +0100, John Ogness wrote:
> The irq chip function gpio_set_irq_type() correctly sets the i.MX
> registers but does not set the irq handler.
I assume you see some breakage without your patch? In mainline?
> This means that all
> gpio-based irq's are handled with handle_edge_irq().
This is not true in mainline, until 060d20d (imx/gpio: Use
handle_level_irq) (currently in imx/mxc-master) hits Linus' tree ...
> This patch corrects this by also setting the appropriate handler.
>
> This patch is against 2.6.32-rc8.
... so there is no hurry.
Can you please test with 060d20d if your breakage still occurs and
if it is still valid report some details (for me and the commit log)?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2009-11-26 7:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-25 18:19 John Ogness
2009-11-26 7:57 ` Uwe Kleine-König [this message]
2009-11-27 23:46 ` Thomas Gleixner
2009-11-29 20:27 ` Uwe Kleine-König
2009-11-30 9:32 ` Thomas Gleixner
2009-11-30 16:29 ` Uwe Kleine-König
2009-11-30 15:47 ` [PATCH] MAINTAINERS: add tree and file pattern for ARM IMX Uwe Kleine-König
2009-11-30 15:53 ` [PATCH v2] " Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091126075724.GA12179@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=john.ogness@linutronix.de \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®