mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andreas Mohr <andi@lisas.de>
To: Takashi Iwai <tiwai@suse.de>
Cc: wuzhangjin@gmail.com, Andreas Mohr <andi@lisas.de>,
	ralf@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: snd_usb_audio OOPS on MIPSEL - is that the mmap issue?
Date: Thu, 26 Nov 2009 10:22:36 +0100	[thread overview]
Message-ID: <20091126092236.GA22408@rhlx01.hs-esslingen.de> (raw)
In-Reply-To: <s5h7htdodov.wl%tiwai@suse.de>

Hi,

On Thu, Nov 26, 2009 at 10:09:04AM +0100, Takashi Iwai wrote:
> > This bug is really bad, Takashi Iwai and Ralf had a plan to add a
> > dma_mmap_coherent() function for 2.6.34 to fix it eventually.
> > 
> > but for 2.6.33, perhaps that patch is a good temp solution(not enough
> > for the whole bug, but minimally) ;)
> 
> I found a problem with that fix, namely, it doesn't distinguish the
> cases whether it's from dma_alloc_coherent() or directly from
> get_free_pages().  In the latter case, it'd do a wrong address
> conversion.
> 
> I'll try to fix up this issue so that my dma_mmap_coherent()
> conversion can be merged more smoothly in the ALSA core side, and
> report back.

Many thanks to both of you! I'll possibly try either the unmodified patch
or an updated version soon (unless I decide to yank that entire non-working
appliance to /dev/null for the near future, that is ;).

Andreas Mohr

  reply	other threads:[~2009-11-26  9:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-25 23:12 Andreas Mohr
2009-11-26  1:20 ` Wu Zhangjin
2009-11-26  9:09   ` Takashi Iwai
2009-11-26  9:22     ` Andreas Mohr [this message]
2009-11-26 18:15     ` Ralf Baechle
2009-11-27  8:36       ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091126092236.GA22408@rhlx01.hs-esslingen.de \
    --to=andi@lisas.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ralf@linux-mips.org \
    --cc=tiwai@suse.de \
    --cc=wuzhangjin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®