From: Alexey Dobriyan <adobriyan@gmail.com>
To: xiyou.wangcong@gmail.com
Cc: jengelh@medozas.de, linux-kernel@vger.kernel.org
Subject: Re: Programs die when max_map_count is too large
Date: Thu, 26 Nov 2009 19:48:46 +0300 [thread overview]
Message-ID: <20091126164846.GA22709@x200.malnet.ru> (raw)
> IMO, the problem is 'sysctl_max_map_count' is actually signed int,
> while when writing to it, the value is treated as unsigned.
The problem is the loop in simple_strtoul(), some people were so afraid
to touch so they even came up with strict_* variants.
> A better fix which I could imagine is to fix sysctl to understand
> signed int's.
- int map_count;
+ unsigned int map_count;
This is incomplete at least.
next reply other threads:[~2009-11-26 16:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-26 16:48 Alexey Dobriyan [this message]
2009-11-27 6:30 ` Américo Wang
-- strict thread matches above, loose matches on Subject: below --
2009-11-26 15:01 Jan Engelhardt
2009-11-26 16:16 ` Américo Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091126164846.GA22709@x200.malnet.ru \
--to=adobriyan@gmail.com \
--cc=jengelh@medozas.de \
--cc=linux-kernel@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome