From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: linux-kernel@vger.kernel.org, mhiramat@redhat.com
Cc: kosaki.motohiro@jp.fujitsu.com, dhowells@redhat.com,
hidehiro.kawai.ez@hitachi.com, lethal@linux-sh.org,
mingo@elte.hu, oleg@redhat.com, roland@redhat.com,
vapier@gentoo.org
Subject: Re: + binfmt-introduce-coredump-parameter-structure.patch added to -mm tree
Date: Thu, 26 Nov 2009 17:53:24 +0900 (JST) [thread overview]
Message-ID: <20091126174835.5A73.A69D9226@jp.fujitsu.com> (raw)
In-Reply-To: <200911202212.nAKMCF2v012068@imap1.linux-foundation.org>
Hi Hiramatsu-san,
>
> The patch titled
> binfmt: introduce coredump parameter structure
> has been added to the -mm tree. Its filename is
> binfmt-introduce-coredump-parameter-structure.patch
>
> Before you just go and hit "reply", please:
> a) Consider who else should be cc'ed
> b) Prefer to cc a suitable mailing list as well
> c) Ideally: find the original patch on the mailing list and do a
> reply-to-all to that, adding suitable additional cc's
>
> *** Remember to use Documentation/SubmitChecklist when testing your code ***
>
> See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
> out what to do about this
>
> The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
>
> ------------------------------------------------------
> Subject: binfmt: introduce coredump parameter structure
> From: Masami Hiramatsu <mhiramat@redhat.com>
>
> These patches are for fixing coredump mm->flags consistency issue.
>
> ---
> 1787 if (mm->core_state || !get_dumpable(mm)) { <- (1)
> 1788 up_write(&mm->mmap_sem);
> 1789 put_cred(cred);
> 1790 goto fail;
> 1791 }
> 1792
> [...]
> 1798 if (get_dumpable(mm) == 2) { /* Setuid core dump mode */ <-(2)
> 1799 flag = O_EXCL; /* Stop rewrite attacks */
> 1800 cred->fsuid = 0; /* Dump root private */
> 1801 }
> ---
>
> Since dumpable bits are not protected by lock, there is a chance to change
> these bits between (1) and (2).
>
> To solve this issue, this patch copies mm->flags to
> coredump_params.mm_flags at the beginning of do_coredump() and uses it
> instead of get_dumpable() while dumping core. This series also introduce
> coredump parameter structure for simplify bimfmt->core_dump interface.
>
>
>
> This patch:
>
> Introduce coredump parameter data structure (struct coredump_params) for
> simplifying binfmt->core_dump() arguments. This also cleanup DUMP_WRITE()
> in elf_core_dump() by style issue.
This patch break ia64 because arch specific ELF_CORE_EXTRA_PHDRS and
ELF_CORE_WRITE_EXTRA_DATA still use DUMP_WRITE. I expect this patch
break uml too.
next parent reply other threads:[~2009-11-26 8:53 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200911202212.nAKMCF2v012068@imap1.linux-foundation.org>
2009-11-26 8:53 ` KOSAKI Motohiro [this message]
2009-11-26 15:50 ` Masami Hiramatsu
2009-11-26 16:51 ` Oleg Nesterov
2009-11-29 3:59 ` Masami Hiramatsu
2009-11-29 4:39 ` [PATCH v2] mm: Introduce coredump parameter structure Masami Hiramatsu
2009-11-29 4:41 ` Masami Hiramatsu
2009-11-29 15:10 ` [PATCH][RFC] tracepoint: signal coredump (Re: [PATCH v2] mm: Introduce coredump parameter structure) Masami Hiramatsu
2009-12-02 20:46 ` [PATCH v2] [RFC] tracepoint: Add signal coredump tracepoint Masami Hiramatsu
2009-12-03 10:39 ` Ingo Molnar
2009-12-03 11:32 ` Masami Hiramatsu
2009-12-05 7:16 ` Ingo Molnar
2009-12-07 17:19 ` Masami Hiramatsu
2009-12-05 7:18 ` KOSAKI Motohiro
2009-12-07 15:25 ` Masami Hiramatsu
2009-12-08 1:51 ` KOSAKI Motohiro
2009-12-08 20:40 ` [PATCH v3] " Masami Hiramatsu
2009-12-09 5:34 ` KOSAKI Motohiro
2009-12-09 16:07 ` Masami Hiramatsu
2009-12-09 16:16 ` Masami Hiramatsu
2009-12-09 20:38 ` [PATCH v4] " Masami Hiramatsu
2009-12-10 0:09 ` KOSAKI Motohiro
2009-12-02 0:18 ` [PATCH v2] mm: Introduce coredump parameter structure Andrew Morton
2009-12-02 0:27 ` KOSAKI Motohiro
2009-12-02 0:29 ` Masami Hiramatsu
2009-12-02 9:50 ` Ingo Molnar
2009-12-02 18:07 ` Masami Hiramatsu
2009-12-02 0:41 ` [PATCH v2] [RESEND] " Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091126174835.5A73.A69D9226@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=dhowells@redhat.com \
--cc=hidehiro.kawai.ez@hitachi.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@redhat.com \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
--cc=roland@redhat.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®