From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Grazvydas Ignotas <notasas@gmail.com>
Cc: avorontsov@ru.mvista.com, linux-kernel@vger.kernel.org,
Madhusudhan Chikkature <madhu.cr@ti.com>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH] power_supply: Add driver for TWL4030/TPS65950 BCI charger
Date: Fri, 27 Nov 2009 16:23:22 +0000 [thread overview]
Message-ID: <20091127162321.GF29512@sirena.org.uk> (raw)
In-Reply-To: <6ed0b2680911270747k4bd5610eg1e0ef83c41622bba@mail.gmail.com>
On Fri, Nov 27, 2009 at 05:47:40PM +0200, Grazvydas Ignotas wrote:
> On Fri, Nov 27, 2009 at 4:54 PM, Anton Vorontsov
> >> + ? ? /* WORKAROUND for lockdep forcing IRQF_DISABLED on us, which
> >> + ? ? ?* we don't want and can't tolerate. ?Although it might be
> >> + ? ? ?* friendlier not to borrow this thread context...
> >> + ? ? ?*/
> >> + ? ? local_irq_enable();
> >> +#endif
> > Can you explain why the driver can't tolerate disabled irqs?
> > Calling schedule_delayed_work() from an irq context should be OK.
> Ah, this is leftover from TI code this driver is based on, which used
> to do more things directly in interrupt handler. So I guess it can be
> removed, updated patch attached.
Actually, the genirq infrastructure in 2.6.32 has been improved to allow
I2C based interrupt controllers properly so even those twl4030 drivers
that do I/O in interrupt callbacks should now be able to run without
these workarounds once the core has been updated.
next prev parent reply other threads:[~2009-11-27 16:23 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-27 14:44 Grazvydas Ignotas
2009-11-27 14:54 ` Anton Vorontsov
2009-11-27 15:47 ` Grazvydas Ignotas
2009-11-27 16:23 ` Mark Brown [this message]
2009-11-30 18:45 ` Madhusudhan
2009-11-30 18:58 ` Anton Vorontsov
2009-12-02 20:38 ` Grazvydas Ignotas
2009-12-02 21:27 ` Anton Vorontsov
2009-12-02 21:32 ` Grazvydas Ignotas
2009-11-30 21:33 ` Grazvydas Ignotas
2009-12-02 16:59 ` Madhusudhan
2009-12-02 17:33 ` Felipe Balbi
2009-12-02 20:34 ` Grazvydas Ignotas
2009-12-02 20:49 ` Felipe Balbi
2009-12-02 21:29 ` Grazvydas Ignotas
2009-12-02 21:54 ` Anton Vorontsov
2009-12-02 22:31 ` Felipe Balbi
2009-12-02 22:59 ` Anton Vorontsov
2009-12-03 8:39 ` Felipe Balbi
2009-12-03 10:55 ` Grazvydas Ignotas
2009-12-03 11:03 ` Felipe Balbi
2009-12-10 14:09 ` Grazvydas Ignotas
2009-12-10 14:18 ` Anton Vorontsov
2009-12-10 14:21 ` Felipe Balbi
2009-12-10 14:44 ` Anton Vorontsov
2009-12-10 16:51 ` Felipe Balbi
2009-12-10 20:51 ` Grazvydas Ignotas
2009-12-11 11:31 ` [RFC/PATCH 0/5] usb transceiver notifier Felipe Balbi
2009-12-11 11:31 ` [RFC/PATCH 1/5] usb: otg: add notifier support Felipe Balbi
2009-12-11 11:55 ` Mark Brown
2009-12-11 11:58 ` Felipe Balbi
2010-01-26 11:16 ` David Brownell
2010-01-26 13:11 ` Mark Brown
2010-01-26 13:35 ` David Brownell
2010-01-26 14:14 ` Felipe Balbi
2010-01-26 14:24 ` Oliver Neukum
2010-01-26 14:30 ` Felipe Balbi
2010-01-26 15:16 ` David Brownell
2010-01-26 15:21 ` David Brownell
2010-01-26 18:50 ` Felipe Balbi
2010-01-26 14:21 ` Mark Brown
2010-01-26 15:44 ` David Brownell
2010-01-26 16:13 ` Mark Brown
2010-01-26 14:10 ` Felipe Balbi
2010-01-26 14:19 ` Felipe Balbi
2010-01-26 15:33 ` David Brownell
2010-01-26 15:07 ` David Brownell
2010-01-26 19:09 ` Felipe Balbi
2010-01-26 19:15 ` Felipe Balbi
2009-12-11 11:31 ` [RFC/PATCH 2/5] usb: otg: twl4030: add support for notifier Felipe Balbi
2009-12-11 17:22 ` sai pavan
2009-12-11 20:40 ` Felipe Balbi
2009-12-12 18:34 ` Mark Brown
2009-12-14 10:30 ` [RFC/PATCH 0/4] twl4030 threaded_irq support Felipe Balbi
2010-01-26 7:06 ` David Brownell
2010-01-26 7:36 ` David Brownell
2010-01-26 10:07 ` Mark Brown
2010-01-26 11:02 ` Felipe Balbi
2010-01-26 12:18 ` David Brownell
2009-12-14 10:30 ` [RFC/PATCH 1/4] input: keyboard: twl4030: move to request_threaded_irq Felipe Balbi
2009-12-14 10:30 ` [RFC/PATCH 2/4] input: misc: " Felipe Balbi
2009-12-14 11:31 ` Shilimkar, Santosh
2009-12-14 11:40 ` Felipe Balbi
2009-12-14 13:16 ` Shilimkar, Santosh
2009-12-14 10:30 ` [RFC/PATCH 3/4] rtc: " Felipe Balbi
2009-12-14 10:30 ` [RFC/PATCH 4/4] usb: otg: " Felipe Balbi
2009-12-11 11:31 ` [RFC/PATCH 3/5] usb: musb: add support for ulpi block Felipe Balbi
2009-12-11 11:31 ` [RFC/PATCH 4/5] usb: musb: isp1704: add registers from isp1704 Felipe Balbi
2009-12-11 12:35 ` Krogerus Heikki (EXT-Teleca/Helsinki)
2009-12-11 12:57 ` Felipe Balbi
2009-12-11 11:31 ` [RFC/PATCH 5/5] usb: musb: musb supports otg notifier Felipe Balbi
2009-12-11 11:40 ` Felipe Balbi
2009-12-30 19:07 ` [PATCH] power_supply: Add driver for TWL4030/TPS65950 BCI charger Madhusudhan
2009-12-10 14:19 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091127162321.GF29512@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=avorontsov@ru.mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=madhu.cr@ti.com \
--cc=notasas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®