Re: [PATCH] fs/ext2: ext2_readdir comment about returns

[Jan Kara <jack@suse.cz>]

  Hello,

On Mon 30-11-09 00:30:55, Jérémy Cochoy wrote:
> From:Jeremy Cochoy <jeremy.cochoy@gmail.com>
> I submit a short correction about a comment in ext2/dir.c
> 
> (I've already send it but it wasn't the good patch format and i didn't
> cc the right people.)
> 
> PS: Please excuse me if I make mistakes with the netiquette, it's my
> first patch and i wich to send more useful patchs next time, without
> hurting your eyes.
  Thanks for the patch. I'd like to point you to the
Documentation/SubmittingPatches document where is described how a proper
patch submission should look like. Most importantly I miss a Signed-off-by
line (item 12 in the document) - without it the patch cannot be merged.
Also your description in the subject is inaccurate. In my opinion it should
rather be:
ext2: Fixup description of ext2_find_entry
  Finally, it's easier to handle submitted patches with git tools when the
body of email looks like:
Something I want in the changelog additionally to mail subject line
(probably empty in your case).
---
Something that I want to say but should not end up in the changelog.

Patch.

Seeing that you have probably generated your patch from git, git
format-patch and git send-email are useful commands for submitting patches
via email.

								Honza