From: Arjan van de Ven <arjan@infradead.org>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: "Ingo Molnar" <mingo@elte.hu>,
"Frédéric Weisbecker" <f.weisbecker@gmail.com>,
"Arnaldo Carvalho de Melo" <acme@infradead.org>,
"Peter Zijlstra" <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] perf timechart: Remove open-coded event parsing code
Date: Mon, 30 Nov 2009 22:24:31 -0800 [thread overview]
Message-ID: <20091130222431.78a300e7@infradead.org> (raw)
In-Reply-To: <4B14B21C.2040406@cn.fujitsu.com>
On Tue, 01 Dec 2009 14:05:16 +0800
Li Zefan <lizf@cn.fujitsu.com> wrote:
> - size = 8;
> + if (!(sample_type & PERF_SAMPLE_RAW)) {
> + fprintf(stderr,
> + "No trace sample to read. Did you call perf
> record "
> + "without -R?");
> + return -1;
> }
while I like your cleanup... I am not so sure this printk makes sense
whatsoever.... the user did not use "perf record" to get here...
--
Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
next prev parent reply other threads:[~2009-12-01 6:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-01 6:04 [PATCH 1/2] perf annotate: Fix perf data parsing Li Zefan
2009-12-01 6:05 ` [PATCH 2/2] perf timechart: Remove open-coded event parsing code Li Zefan
2009-12-01 6:24 ` Arjan van de Ven [this message]
2009-12-01 6:31 ` Li Zefan
2009-12-01 7:31 ` [tip:perf/core] " tip-bot for Li Zefan
2009-12-01 7:30 ` [tip:perf/core] perf annotate: Fix perf data parsing tip-bot for Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091130222431.78a300e7@infradead.org \
--to=arjan@infradead.org \
--cc=acme@infradead.org \
--cc=f.weisbecker@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome