mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mel Gorman <mel@csn.ul.ie>
To: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
Cc: pm list <linux-pm@lists.linux-foundation.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Kernel Testers List <kernel-testers@vger.kernel.org>,
	"Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: Bisected: s2disk (uswsusp only) hangs just before poweroff
Date: Wed, 2 Dec 2009 10:35:38 +0000	[thread overview]
Message-ID: <20091202103538.GB1457@csn.ul.ie> (raw)
In-Reply-To: <4B162BE1.7070709@tuffmail.co.uk>

On Wed, Dec 02, 2009 at 08:57:05AM +0000, Alan Jenkins wrote:
> Mel Gorman wrote:
>> On Tue, Dec 01, 2009 at 07:59:40PM +0000, Alan Jenkins wrote:
>>   
>>> Hi
>>>
>>> Suspend to disk is (sometimes) hanging for me in 2.6.32-rc.  I 
>>> finally  got around to bisecting it, which blamed the following 
>>> commit by Mel:
>>>
>>> 5f8dcc2 "page-allocator: split per-cpu list into one-list-per-migrate-type"
>>>
>>> I was able to confirm this by reverting the commit, which fixed the   
>>> hang.  I had to revert one other commit first to avoid a conflict:
>>>
>>> a6f9edd "page-allocator: maintain rolling count of pages to free from 
>>>  the PCP"
>>>
>>>     
>>
>> Which RC kernel? Specifically, are the commits
>>
>> cc4a6851466039a8a688c843962a05689059ff3b always wake kswapd when restarting an allocation attempt
>> 9d0ed60fe9cd1fbf57f755cd27a23ae9114d7210 Do not allow interrupts to use ALLOC_HARDER
>>
>> applied?
>>
>> The latter one in particular might make a difference if s2disk is
>> pushing the system far below the watermarks. I don't suppose you know
>> where it's hanging? i.e. is it hanging in the allocator itself?
>>
>> If those patches are applied, then one difference that 5f8dcc2 makes is
>> that pages on the PCP lists but not of the right migratetype are not
>> used. Prior to that commit, an allocation might succeed even if the
>> buddy lists were empty because one of the other PCP page types would be
>> used.
>>
>>   
>>> -- detail --
>>>
>>> When I suspend my EeePc 701 to disk, it sometimes hangs after writing 
>>>  out the hibernation image.  The system is still able to resume from 
>>> this  image (after working around the hang by pressing the power 
>>> button). 
>>>
>>> This is specific to s2disk from the uswsusp package (which is now   
>>> installed by default on debian unstable).  It doesn't happen if I   
>>> uninstall uswsusp and use the in-kernel suspend instead.
>>>
>>>     
>>
>> This leads me to believe that uswsusp is able to push available pages
>> far below what is expected. It's a total guess though, I have no idea
>> how uswsusp is implemented or how it differs from what is in kernel.
>>
>>   
>>> The hang doesn't happen if I boot with "init=/bin/bash" and run 
>>> s2disk.   Nor does it happen if I boot normally, then switch to 
>>> single user mode  ("telinit 12").
>>>
>>> It only happens if I've logged in to KDE.  In the past, this has   
>>> indicated a problem in a network driver, since NetworkManager only 
>>> made  a connection once I logged in.  But it still hangs if I remove 
>>> both  ath5k and atl2 before I log into KDE.  (I actually tried 
>>> removing as  many modules as possible: atl2, ath5k, usbcore, 
>>> snd-hda-intel, psmouse,  pcspkr, battery, ac, themal, fan, and 
>>> eeepc-laptop).  Perhaps it's  something to do with the size of the 
>>> hibernation image.
>>>
>>>     
>>
>> I believe you are correct in that it's something to do with the size of
>> the hibernation image and how close to the edge the kernel gets pushed
>> as a result.
>>
>> Please confirm first that the two commits I mentioned above are in your
>> kernel. If not, would you mind trying the following patch?
>> Unfortunately, it's totally untested. The intention of the patch is to
>> use other PCP lists if the desired one cannot be refilled.
>>
>> Thanks.
>>   
>
> The hang happens on 2.6.32-rc8, which includes the two commits above.
>

Ok, that was somewhat expected as they only had an impact if there was a
storm of interrupts which was unlikely in this case. How about the
additional patch?

-- 
Mel Gorman
Part-time Phd Student                          Linux Technology Center
University of Limerick                         IBM Dublin Software Lab

  reply	other threads:[~2009-12-02 10:35 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-01 19:59 Alan Jenkins
2009-12-01 20:24 ` Justin P. Mattock
2009-12-01 20:27   ` Alan Jenkins
2009-12-01 21:14     ` Justin P. Mattock
2009-12-01 21:45 ` Mel Gorman
2009-12-01 21:53   ` Rafael J. Wysocki
2009-12-02 11:49     ` Alan Jenkins
2009-12-02 12:20       ` Mel Gorman
2009-12-02 14:25         ` Alan Jenkins
2009-12-02 14:28         ` [PATCH] uswsusp: automatically free the in-memory image once s2disk has finished with it Alan Jenkins
2009-12-02 21:11           ` Pavel Machek
2009-12-02 22:07             ` Mel Gorman
2009-12-02 22:15               ` Pavel Machek
2009-12-02 22:25                 ` Mel Gorman
2009-12-02 23:22                   ` Rafael J. Wysocki
2009-12-03  7:53                   ` Pavel Machek
2009-12-03 12:57                     ` Alan Jenkins
2009-12-03 14:50                       ` Mel Gorman
2009-12-08  0:37                         ` Alan Jenkins
2009-12-11 10:53                           ` Mel Gorman
2009-12-14 11:08                             ` Pavel Machek
2009-12-03 19:50                       ` Rafael J. Wysocki
2009-12-03 20:16                       ` Pavel Machek
2009-12-02 21:47           ` Rafael J. Wysocki
2009-12-02  8:57   ` Bisected: s2disk (uswsusp only) hangs just before poweroff Alan Jenkins
2009-12-02 10:35     ` Mel Gorman [this message]
2009-12-02 11:35       ` Alan Jenkins
2009-12-02 11:11   ` Alan Jenkins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091202103538.GB1457@csn.ul.ie \
    --to=mel@csn.ul.ie \
    --cc=alan-jenkins@tuffmail.co.uk \
    --cc=kernel-testers@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®