From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753930AbZLBMrZ (ORCPT ); Wed, 2 Dec 2009 07:47:25 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753754AbZLBMrY (ORCPT ); Wed, 2 Dec 2009 07:47:24 -0500 Received: from one.firstfloor.org ([213.235.205.2]:51226 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753513AbZLBMrY (ORCPT ); Wed, 2 Dec 2009 07:47:24 -0500 Date: Wed, 2 Dec 2009 13:47:30 +0100 From: Andi Kleen To: Wu Fengguang Cc: Andi Kleen , Andrew Morton , Nick Piggin , linux-mm@kvack.org, LKML Subject: Re: [PATCH 14/24] HWPOISON: return 0 if page is assured to be isolated Message-ID: <20091202124730.GB18989@one.firstfloor.org> References: <20091202031231.735876003@intel.com> <20091202043045.394560341@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091202043045.394560341@intel.com> User-Agent: Mutt/1.4.2.2i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 02, 2009 at 11:12:45AM +0800, Wu Fengguang wrote: > Introduce hpc.page_isolated to record if page is assured to be > isolated, ie. it won't be accessed in normal kernel code paths > and therefore won't trigger another MCE event. > > __memory_failure() will now return 0 to indicate that page is > really isolated. Note that the original used action result > RECOVERED is not a reliable criterion. > > Note that we now don't bother to risk returning 0 for the > rare unpoison/truncated cases. That's the only user of the new hwpoison_control structure right? I think I prefer for that single bit to extend the return values and keep the arguments around. structures are not nice to read. I'll change the code. -Andi