mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjan@infradead.org>
To: liu pf <kernelfans@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Should we use preempt_disable() in sleep_on_common()?
Date: Wed, 2 Dec 2009 23:07:46 -0800	[thread overview]
Message-ID: <20091202230746.611f7fc5@infradead.org> (raw)
In-Reply-To: <563a732e0912022249y1e831c6cv7f2d5d376b8a5f63@mail.gmail.com>

On Thu, 3 Dec 2009 14:49:14 +0800
liu pf <kernelfans@gmail.com> wrote:

> Hi:
> 
> I am puzzled with the following scenario. Could anyone enlighten me?


sleep_on family of APIs is very racy and just cannot be used correctly;
I'm not surprised that there's a preempt race in it, but trust me, it's
not the biggest race... never ever use these APIs!!!


-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org

  reply	other threads:[~2009-12-03  7:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-03  6:49 liu pf
2009-12-03  7:07 ` Arjan van de Ven [this message]
2009-12-03  7:12   ` Dmitry Torokhov
2009-12-03  7:15     ` Dmitry Torokhov
2009-12-03  8:15     ` liu pf
2009-12-03  8:22       ` Dmitry Torokhov
2009-12-03  8:53         ` liu pf
2009-12-03  7:57 ` Dmitry Adamushko
2009-12-03  8:01   ` liu pf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091202230746.611f7fc5@infradead.org \
    --to=arjan@infradead.org \
    --cc=kernelfans@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®