Re: [PATCH] DMI: allow omitting ident strings in DMI tables

[Jean Delvare <khali@linux-fr.org>]

On Thu, 3 Dec 2009 00:56:30 -0800, Dmitry Torokhov wrote:
> On Thu, Dec 03, 2009 at 09:30:09AM +0100, Jean Delvare wrote:
> > On Wed, 2 Dec 2009 19:12:40 -0800, Dmitry Torokhov wrote:
> > > diff --git a/drivers/firmware/dmi_scan.c b/drivers/firmware/dmi_scan.c
> > > index 938100f..9116aa7 100644
> > > --- a/drivers/firmware/dmi_scan.c
> > > +++ b/drivers/firmware/dmi_scan.c
> > > @@ -440,6 +440,15 @@ static bool dmi_matches(const struct dmi_system_id *dmi)
> > >  }
> > >  
> > >  /**
> > > + *	dmi_is_end_of_table - check for end-of-table marker
> > > + *	@dmi: pointer to the dmi_system_id structure to check
> > > + */
> > > +static bool dmi_is_end_of_table(const struct dmi_system_id *dmi)
> > > +{
> > > +	return dmi->ident == NULL && dmi->matches[0].slot == DMI_NONE;
> > 
> > If you really want to allow for dmi->ident == NULL, then I guess you can
> > _only_ check for dmi->matches[0].slot == DMI_NONE. I can't think of any
> > legitimate use of DMI_NONE for a used slot.
> 
> Current behavior is that entry with ident and empty match table matches
> everything. If we only check on the first slot then it will not match. I
> wanted to preserve the current behavior.

Is there a use case for this behavior? If not then I don't see the
point of preserving it.

-- 
Jean Delvare