From: Ingo Molnar <mingo@elte.hu>
To: Mikael Pettersson <mikpe@it.uu.se>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
Joerg Roedel <joerg.roedel@amd.com>,
Andreas Herrmann <andreas.herrmann3@amd.com>,
Yinghai Lu <yinghai@kernel.org>,
Suresh Siddha <suresh.b.siddha@intel.com>
Subject: Re: [PATCH 2.6.32] x86: enable lapic nmi watchdog on AMD Family 11h
Date: Thu, 3 Dec 2009 16:29:52 +0100 [thread overview]
Message-ID: <20091203152952.GA27324@elte.hu> (raw)
In-Reply-To: <19223.53436.931768.278021@pilspetsen.it.uu.se>
* Mikael Pettersson <mikpe@it.uu.se> wrote:
> The x86 lapic nmi watchdog does not recognize AMD Family 11h,
> resulting in:
>
> NMI watchdog: CPU not supported
>
> As far as I can see from available documentation (the BKDM), family
> 11h looks identical to family 10h as far as the PMU is concerned.
>
> Extending the check to accept family 11h results in:
>
> Testing NMI watchdog ... OK.
>
> I've been running with this change on a Turion X2 Ultra ZM-82 laptop
> for a couple of weeks now without problems.
Applied, thanks Mikael!
Long term i think we want to use the PMU driver to support the NMI tick,
that way all new CPUs that have PMU support will get NMI watchdog
support too, automatically.
That's a more complex change though and there's no reason not to apply
this simple patch of yours. Btw., do you [or anyone else] have
interest/time to pursue the more complex angle as well? It would be a
nice feature.
Ingo
next prev parent reply other threads:[~2009-12-03 15:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-03 14:52 Mikael Pettersson
2009-12-03 15:29 ` Ingo Molnar [this message]
2009-12-03 15:36 ` [tip:x86/apic] x86, apic: Enable " tip-bot for Mikael Pettersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091203152952.GA27324@elte.hu \
--to=mingo@elte.hu \
--cc=andreas.herrmann3@amd.com \
--cc=joerg.roedel@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikpe@it.uu.se \
--cc=suresh.b.siddha@intel.com \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome