From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756226AbZLCTlk (ORCPT ); Thu, 3 Dec 2009 14:41:40 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756052AbZLCTlk (ORCPT ); Thu, 3 Dec 2009 14:41:40 -0500 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:37149 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755333AbZLCTlj (ORCPT ); Thu, 3 Dec 2009 14:41:39 -0500 Date: Thu, 3 Dec 2009 19:41:32 +0000 From: Russell King - ARM Linux To: Wan ZongShun Cc: linux-arm-kernel , linux-kernel Subject: Re: [PATCH 4/4]ARM: NUC900: enable uart support for nuc932 Message-ID: <20091203194132.GA27666@n2100.arm.linux.org.uk> References: <4B167281.1090708@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4B167281.1090708@gmail.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 02, 2009 at 09:58:25PM +0800, Wan ZongShun wrote: > diff --git a/arch/arm/mach-w90x900/clock.h b/arch/arm/mach-w90x900/clock.h > index b9ea2e6..2a2a54a 100644 > --- a/arch/arm/mach-w90x900/clock.h > +++ b/arch/arm/mach-w90x900/clock.h > @@ -14,8 +14,10 @@ > > #ifndef CONFIG_CPU_NUC932 > #define EXTCLK 15000000 > +#define UARTCLK 11313600 > #else > #define EXTCLK 27000000 > +#define UARTCLK 57139200 > #endif As far as I can see, these are the only thing which prevent a single kernel being built to cover both NUC900 and NUC932. Can we make their selection something which is done at runtime instead of compile time? This comments goes for patch 5837/1 in the patch system as well.