mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Eric Paris <eparis@redhat.com>
To: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org
Cc: viro@zeniv.linux.org.uk, jmorris@namei.org, npiggin@suse.de,
	eparis@redhat.com, zohar@us.ibm.com, jack@suse.cz,
	jmalicki@metacarta.com, dsmith@redhat.com, serue@us.ibm.com,
	hch@lst.de, john@johnmccutchan.com, rlove@rlove.org,
	ebiederm@xmission.com, heiko.carstens@de.ibm.com,
	penguin-kernel@I-love.SAKURA.ne.jp, mszeredi@suse.cz,
	jens.axboe@oracle.com, akpm@linux-foundation.org, matthew@wil.cx,
	hugh.dickins@tiscali.co.uk, kamezawa.hiroyu@jp.fujitsu.com,
	nishimura@mxp.nes.nec.co.jp, davem@davemloft.net, arnd@arndb.de,
	eric.dumazet@gmail.com
Subject: [RFC PATCH 6/6] fs: move get_empty_filp() deffinition to internal.h
Date: Thu, 03 Dec 2009 14:59:33 -0500	[thread overview]
Message-ID: <20091203195933.8925.8783.stgit@paris.rdu.redhat.com> (raw)
In-Reply-To: <20091203195851.8925.30926.stgit@paris.rdu.redhat.com>

All users outside of fs/ of get_empty_filp() have been removed.  This patch
moves the definition from the include/ directory to internal.h so no new
users crop up and removes the EXPORT_SYMBOL.  I'd love to see open intents
stop using it too, but that's a problem for another day and a smarter
developer!

Signed-off-by: Eric Paris <eparis@redhat.com>
---

 fs/file_table.c    |    4 ++--
 fs/internal.h      |    1 +
 fs/namei.c         |    2 ++
 fs/open.c          |    2 ++
 include/linux/fs.h |    1 -
 5 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/fs/file_table.c b/fs/file_table.c
index 0f9d2f2..629a167 100644
--- a/fs/file_table.c
+++ b/fs/file_table.c
@@ -24,6 +24,8 @@
 
 #include <asm/atomic.h>
 
+#include "internal.h"
+
 /* sysctl tunables... */
 struct files_stat_struct files_stat = {
 	.max_files = NR_FILE
@@ -147,8 +149,6 @@ fail:
 	return NULL;
 }
 
-EXPORT_SYMBOL(get_empty_filp);
-
 /**
  * init_file - initialize a 'struct file'
  * @file: the already allocated 'struct file' to initialized
diff --git a/fs/internal.h b/fs/internal.h
index 515175b..f67cd14 100644
--- a/fs/internal.h
+++ b/fs/internal.h
@@ -79,6 +79,7 @@ extern void chroot_fs_refs(struct path *, struct path *);
  * file_table.c
  */
 extern void mark_files_ro(struct super_block *);
+extern struct file *get_empty_filp(void);
 
 /*
  * super.c
diff --git a/fs/namei.c b/fs/namei.c
index 87f97ba..d7ecd2f 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -35,6 +35,8 @@
 #include <linux/fs_struct.h>
 #include <asm/uaccess.h>
 
+#include "internal.h"
+
 #define ACC_MODE(x) ("\000\004\002\006"[(x)&O_ACCMODE])
 
 /* [Feb-1997 T. Schoebel-Theuer]
diff --git a/fs/open.c b/fs/open.c
index fa3bf4c..ebb74d4 100644
--- a/fs/open.c
+++ b/fs/open.c
@@ -31,6 +31,8 @@
 #include <linux/falloc.h>
 #include <linux/fs_struct.h>
 
+#include "internal.h"
+
 int vfs_statfs(struct dentry *dentry, struct kstatfs *buf)
 {
 	int retval = -ENODEV;
diff --git a/include/linux/fs.h b/include/linux/fs.h
index 5de1bab..b8ed6bf 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -2192,7 +2192,6 @@ static inline void insert_inode_hash(struct inode *inode) {
 	__insert_inode_hash(inode, inode->i_ino);
 }
 
-extern struct file * get_empty_filp(void);
 extern void file_move(struct file *f, struct list_head *list);
 extern void file_kill(struct file *f);
 #ifdef CONFIG_BLOCK


  parent reply	other threads:[~2009-12-03 20:00 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-03 19:58 [RFC PATCH 1/6] shmem: use alloc_file instead of init_file Eric Paris
2009-12-03 19:59 ` [RFC PATCH 2/6] pipes: use alloc-file instead of duplicating code Eric Paris
2009-12-04  6:08   ` Miklos Szeredi
2009-12-04 18:54     ` Eric Paris
2009-12-04 14:22   ` Jens Axboe
2009-12-03 19:59 ` [RFC PATCH 3/6] inotify: use alloc_file instead of doing it internally Eric Paris
2009-12-04  6:58   ` Miklos Szeredi
2009-12-03 19:59 ` [RFC PATCH 4/6] networking: rework socket to fd mapping using alloc-file Eric Paris
2009-12-03 22:00   ` David Miller
2009-12-03 23:24     ` Eric Paris
2009-12-04  7:09   ` Miklos Szeredi
2009-12-03 19:59 ` [RFC PATCH 5/6] vfs: make init-file static Eric Paris
2009-12-03 22:44   ` Serge E. Hallyn
2009-12-04  4:04     ` Nick Piggin
2009-12-03 19:59 ` Eric Paris [this message]
2009-12-04  7:12   ` [RFC PATCH 6/6] fs: move get_empty_filp() deffinition to internal.h Miklos Szeredi
2009-12-04  5:58 ` [RFC PATCH 1/6] shmem: use alloc_file instead of init_file Miklos Szeredi
2009-12-04 14:19   ` Eric Paris
2009-12-04 15:35 ` Serge E. Hallyn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091203195933.8925.8783.stgit@paris.rdu.redhat.com \
    --to=eparis@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=davem@davemloft.net \
    --cc=dsmith@redhat.com \
    --cc=ebiederm@xmission.com \
    --cc=eric.dumazet@gmail.com \
    --cc=hch@lst.de \
    --cc=heiko.carstens@de.ibm.com \
    --cc=hugh.dickins@tiscali.co.uk \
    --cc=jack@suse.cz \
    --cc=jens.axboe@oracle.com \
    --cc=jmalicki@metacarta.com \
    --cc=jmorris@namei.org \
    --cc=john@johnmccutchan.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=matthew@wil.cx \
    --cc=mszeredi@suse.cz \
    --cc=nishimura@mxp.nes.nec.co.jp \
    --cc=npiggin@suse.de \
    --cc=penguin-kernel@I-love.SAKURA.ne.jp \
    --cc=rlove@rlove.org \
    --cc=serue@us.ibm.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=zohar@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®