From: Randy Dunlap <randy.dunlap@oracle.com>
To: "matteo_cortese@fastwebnet.it" <matteo_cortese@fastwebnet.it>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] make gconfig: fix the "(NEW)" string
Date: Fri, 4 Dec 2009 11:02:28 -0800 [thread overview]
Message-ID: <20091204110228.2ce3345c.randy.dunlap@oracle.com> (raw)
In-Reply-To: <23753252.369201259951904278.JavaMail.defaultUser@defaultHost>
On Fri, 4 Dec 2009 19:38:24 +0100 (CET) matteo_cortese@fastwebnet.it wrote:
> The string "(NEW)" is added to those options that are not present in the
> current config file, thus looking as new features. Alas, the logic seem
> s to be inverted.
Did you just notice that thru source code inspection or via testing of
gconfig?
> Signed-off-by: Matteo Cortese <matteo_cortese@fastwebnet.it>
> ------
>
> diff -u linux-source-2.6.26-old/scripts/kconfig/gconf.c linux-source-2.6
> .26/scripts/kconfig/gconf.c
> --- linux-source-2.6.26-old/scripts/kconfig/gconf.c 2008-07-13 21:51:29.
> 000000000 +0000
> +++ linux-source-2.6.26/scripts/kconfig/gconf.c 2009-01-03 00:52:57.0000
> 00000 +0000
> @@ -1174,7 +1174,7 @@
>
> row[COL_OPTION] =
> g_strdup_printf("%s %s", _(menu_get_prompt(menu)),
> - sym && sym_has_value(sym) ? "(NEW)" : "");
> + sym && !sym_has_value(sym) ? "(NEW)" : "");
>
> if (show_all && !menu_is_visible(menu))
> row[COL_COLOR] = g_strdup("DarkGray");
>
> --
Well, for me, with just some random config file that has
CONFIG_MODULES=y
CONFIG_BLOCK=y
gconfig with this patch says:
Enable loadable module support
Enable the block layer (NEW)
and gconfig without this patch says:
Enable loadable module support (NEW)
Enable the block layer
I'm confuzed. Go figure.
---
~Randy
next prev parent reply other threads:[~2009-12-04 19:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-04 18:38 matteo_cortese
2009-12-04 19:02 ` Randy Dunlap [this message]
2009-12-09 1:40 ` Matteo Cortese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091204110228.2ce3345c.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matteo_cortese@fastwebnet.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®