mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: x86@kernel.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: [PATCH] [2/3] x86: Remove CONFIG_GBPAGES option
Date: Sun,  6 Dec 2009 15:13:10 +0100 (CET)	[thread overview]
Message-ID: <20091206141310.CB4C9B151F@basil.firstfloor.org> (raw)
In-Reply-To: <20091206313.812075626@firstfloor.org>


Support for GB pages mapped direct memory has been around for quite
some time and has not caused any problems as far as I know.

So it's time to remove the CONFIG_GBPAGES option and always enable
it by default. The option only controlled the default anyways, no
code. gbpages can be still disabled at runtime.

Signed-off-by: Andi Kleen <ak@linux.intel.com>

---
 arch/x86/Kconfig   |    9 ---------
 arch/x86/mm/init.c |    6 +-----
 2 files changed, 1 insertion(+), 14 deletions(-)

Index: linux-2.6.32-ak/arch/x86/Kconfig
===================================================================
--- linux-2.6.32-ak.orig/arch/x86/Kconfig
+++ linux-2.6.32-ak/arch/x86/Kconfig
@@ -1110,15 +1110,6 @@ config X86_PAE
 config ARCH_PHYS_ADDR_T_64BIT
 	def_bool X86_64 || X86_PAE
 
-config DIRECT_GBPAGES
-	bool "Enable 1GB pages for kernel pagetables" if EMBEDDED
-	default y
-	depends on X86_64
-	---help---
-	  Allow the kernel linear mapping to use 1GB pages on CPUs that
-	  support it. This can improve the kernel's performance a tiny bit by
-	  reducing TLB pressure. If in doubt, say "Y".
-
 # Common NUMA Features
 config NUMA
 	bool "Numa Memory Allocation and Scheduler Support"
Index: linux-2.6.32-ak/arch/x86/mm/init.c
===================================================================
--- linux-2.6.32-ak.orig/arch/x86/mm/init.c
+++ linux-2.6.32-ak/arch/x86/mm/init.c
@@ -22,11 +22,7 @@ unsigned long __meminitdata e820_table_t
 
 int after_bootmem;
 
-int direct_gbpages
-#ifdef CONFIG_DIRECT_GBPAGES
-				= 1
-#endif
-;
+int direct_gbpages = 1;
 
 static void __init find_early_table_space(unsigned long end, int use_pse,
 					  int use_gbpages)

  reply	other threads:[~2009-12-06 14:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-06 14:13 [PATCH] [1/3] x86: Improve CONFIG_KEXEC_JUMP description Andi Kleen
2009-12-06 14:13 ` Andi Kleen [this message]
2009-12-06 14:13 ` [PATCH] [3/3] Fix unwind annotations for 64bit kernel Andi Kleen
2009-12-07  7:53   ` Jan Beulich
2009-12-07  9:06     ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091206141310.CB4C9B151F@basil.firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome