From: Ingo Molnar <mingo@elte.hu>
To: Ulrich Drepper <drepper@redhat.com>
Cc: a.p.zijlstra@chello.nl, fweisbec@gmail.com,
jaswinderrajput@gmail.com, linux-kernel@vger.kernel.org,
paulus@samba.org
Subject: Re: Minor optimization in parse_subsystem_tracepoint_event
Date: Mon, 7 Dec 2009 08:10:08 +0100 [thread overview]
Message-ID: <20091207071008.GE10868@elte.hu> (raw)
In-Reply-To: <200912061825.nB6IPUa1023306@hs20-bc2-1.build.redhat.com>
* Ulrich Drepper <drepper@redhat.com> wrote:
> Uses of strcat are almost always signs that someone is too lazy to think
> about the code a bit more carefully. One always has to know about the
> lengths of the strings involved to avoid buffer overflows.
>
> This is one case where the size of the object code for me is reduced by
> 38 bytes. The code should also be faster, especially if flags is non-NULL.
>
> Signed-off-by: Ulrich Drepper <drepper@redhat.com>
Applied, thanks a lot Ulrich!
Ingo
next prev parent reply other threads:[~2009-12-07 7:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-06 18:25 Ulrich Drepper
2009-12-07 7:10 ` Ingo Molnar [this message]
2009-12-07 7:12 ` [tip:perf/urgent] perf tools: Optimize parse_subsystem_tracepoint_event() tip-bot for Ulrich Drepper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091207071008.GE10868@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=drepper@redhat.com \
--cc=fweisbec@gmail.com \
--cc=jaswinderrajput@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome